extensions/browser/api/device_permissions_manager.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/device_permissions_manager.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Android, Fuzzer and JSON Test Fixes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/device_permissions_manager.cc

diff --git a/extensions/browser/api/device_permissions_manager.cc b/extensions/browser/api/device_permissions_manager.cc

index 38b2c7645e45a8715e5ed9f12071498a822c8fe0..fc33617ed2cb435299f2c53b3f89945a8c9aedee 100644

--- a/extensions/browser/api/device_permissions_manager.cc

+++ b/extensions/browser/api/device_permissions_manager.cc

@@ -151,7 +151,7 @@ void UpdateDevicePermissionEntry(BrowserContext* context,

if (!MatchesDevicePermissionEntry(dict_value, entry)) {

continue;

}

- devices->Set(i, entry->ToValue().release());

+ devices->Set(i, entry->ToValue());

break;

}