extensions/browser/api/declarative/declarative_api.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/declarative_api.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Android, Fuzzer and JSON Test Fixes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/declarative/declarative_api.cc

diff --git a/extensions/browser/api/declarative/declarative_api.cc b/extensions/browser/api/declarative/declarative_api.cc

index b2393b2c9a375c9b8105b9942482315c60fb85dc..8cd8bd2b05706b911304a6f651aedc359a6b288e 100644

--- a/extensions/browser/api/declarative/declarative_api.cc

+++ b/extensions/browser/api/declarative/declarative_api.cc

@@ -58,7 +58,7 @@ void ConvertBinaryListElementsToBase64(base::ListValue* args) {

if (iter->IsType(base::Value::Type::BINARY)) {

base::Value* binary = NULL;

if (args->GetBinary(index, &binary))

- args->Set(index, ConvertBinaryToBase64(binary).release());

+ args->Set(index, ConvertBinaryToBase64(binary));

} else if (iter->IsType(base::Value::Type::LIST)) {

base::ListValue* list;

iter->GetAsList(&list);