components/json_schema/json_schema_validator_unittest_base.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/json_schema/json_schema_validator_unittest_base.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Android, Fuzzer and JSON Test Fixes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/web_view_impl.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc ('k') | components/policy/core/common/configuration_policy_provider_test.cc » ('j') | content/common/common_param_traits_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/json_schema/json_schema_validator_unittest_base.cc

diff --git a/components/json_schema/json_schema_validator_unittest_base.cc b/components/json_schema/json_schema_validator_unittest_base.cc

index d96544c31d258e6e03beaefd6d6c585960ecaddb..d49bb0679c3f9f0b27a5634a119a9d42e6aab63c 100644

--- a/components/json_schema/json_schema_validator_unittest_base.cc

+++ b/components/json_schema/json_schema_validator_unittest_base.cc

@@ -398,7 +398,7 @@ void JSONSchemaValidatorTestBase::TestArrayTuple() {

ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "1",

JSONSchemaValidator::kArrayItemRequired);

- instance->Set(0, new base::Value(42));

+ instance->Set(0, base::MakeUnique<base::Value>(42));

instance->AppendInteger(42);

ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "0",

JSONSchemaValidator::FormatErrorMessage(

@@ -409,10 +409,10 @@ void JSONSchemaValidatorTestBase::TestArrayTuple() {

base::DictionaryValue* additional_properties = new base::DictionaryValue();

additional_properties->SetString(schema::kType, schema::kAny);

schema->Set(schema::kAdditionalProperties, additional_properties);

- instance->Set(0, new base::Value("42"));

+ instance->Set(0, base::MakeUnique<base::Value>("42"));

instance->AppendString("anything");

ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);

- instance->Set(2, new base::ListValue());

+ instance->Set(2, base::MakeUnique<base::ListValue>());

ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);

additional_properties->SetString(schema::kType, schema::kBoolean);

@@ -421,7 +421,7 @@ void JSONSchemaValidatorTestBase::TestArrayTuple() {

JSONSchemaValidator::kInvalidType,

schema::kBoolean,

schema::kArray));

- instance->Set(2, new base::Value(false));

+ instance->Set(2, base::MakeUnique<base::Value>(false));

ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);

base::ListValue* items_schema = NULL;

@@ -435,7 +435,7 @@ void JSONSchemaValidatorTestBase::TestArrayTuple() {

// for objects.

instance->Set(0, base::MakeUnique<base::Value>());

ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);

- instance->Set(0, new base::Value(42));

+ instance->Set(0, base::MakeUnique<base::Value>(42));

ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "0",

JSONSchemaValidator::FormatErrorMessage(

JSONSchemaValidator::kInvalidType,