components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Android, Fuzzer and JSON Test Fixes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/web_view_impl.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc ('k') | components/json_schema/json_schema_validator_unittest_base.cc » ('j') | content/common/common_param_traits_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc

index 85671575bb39d55218a40577673f3cc0e1c41b02..8d241701f34012a55da48684ff2bd6e378f17cc1 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc

@@ -39,7 +39,7 @@ class DataReductionProxyPrefsTest : public testing::Test {

PrefService* pref_service) {

ListPrefUpdate list(local_state_prefs(), pref_name);

for (int64_t i = 0; i < 10L; ++i) {

- list->Set(i, new base::Value(base::Int64ToString(i + starting_value)));

+ list->AppendString(base::Int64ToString(i + starting_value));

}