Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2838873004: Add PermissionDialogTests for grouped Media requests (Closed)

Created:
3 years, 8 months ago by raymes
Modified:
3 years, 7 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PermissionDialogTests for grouped Media requests This adds tests to PermissionDialogTests that test Media requests with the kUsePermissionManagerForMediaRequests feature enabled. When this feature is enabled, media permissions can be requested in the same way as other permissions. Once the feature flag is removed, the old behavior that is being tested can also be removed. BUG=596786 Review-Url: https://codereview.chromium.org/2838873004 Cr-Commit-Position: refs/heads/master@{#468283} Committed: https://chromium.googlesource.com/chromium/src/+/22831c3c2b720f6fe0c8570912d72ce039abf72c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
M chrome/browser/permissions/permission_request_manager_browsertest.cc View 7 chunks +44 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
raymes
3 years, 8 months ago (2017-04-25 23:36:11 UTC) #2
Timothy Loh
On 2017/04/25 23:36:11, raymes wrote: lgtm
3 years, 7 months ago (2017-04-27 03:51:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838873004/1
3 years, 7 months ago (2017-05-01 03:54:07 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 04:36:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/22831c3c2b720f6fe0c8570912d7...

Powered by Google App Engine
This is Rietveld 408576698