Add PermissionDialogTests for grouped Media requests

chrome/browser/permissions/permission_request_manager_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_request_manager.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
+#include "base/test/scoped_feature_list.h"
 #include "build/build_config.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"
 #include "chrome/browser/custom_handlers/register_protocol_handler_permission_request.h"
 #include "chrome/browser/media/webrtc/media_capture_devices_dispatcher.h"
 #include "chrome/browser/media/webrtc/media_stream_devices_controller.h"
 #include "chrome/browser/permissions/permission_context_base.h"
 #include "chrome/browser/permissions/permission_request_impl.h"
 #include "chrome/browser/permissions/permission_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/test/test_browser_dialog.h"
+#include "chrome/common/chrome_features.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
@@ skipping 174 matching lines @@
       base::Bind(decided), base::Bind(cleanup)));
   return owned_requests_.back().get();
 }
 
 void PermissionDialogTest::ShowDialog(const std::string& name) {
   constexpr const char* kMultipleName = "multiple";
   // Permissions to request for a "multiple" request. Only types handled in
   // PermissionRequestImpl::GetMessageTextFragment() are valid.
   constexpr ContentSettingsType kMultipleRequests[] = {
       CONTENT_SETTINGS_TYPE_GEOLOCATION, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
-      CONTENT_SETTINGS_TYPE_MIDI_SYSEX};
+      CONTENT_SETTINGS_TYPE_MIDI_SYSEX,
+  };
+  constexpr ContentSettingsType kMultipleRequestsWithMedia[] = {
+      CONTENT_SETTINGS_TYPE_GEOLOCATION, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
+      CONTENT_SETTINGS_TYPE_MIDI_SYSEX, CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC,
+      CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA};
   constexpr struct {
     const char* name;
     ContentSettingsType type;
   } kNameToType[] = {
       {"flash", CONTENT_SETTINGS_TYPE_PLUGINS},
       {"geolocation", CONTENT_SETTINGS_TYPE_GEOLOCATION},
       {"protected_media", CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER},
       {"notifications", CONTENT_SETTINGS_TYPE_NOTIFICATIONS},
       {"mic", CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC},
       {"camera", CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA},
@@ skipping 15 matching lines @@
       manager->AddRequest(MakeRegisterProtocolHandlerRequest());
       break;
     case CONTENT_SETTINGS_TYPE_AUTOMATIC_DOWNLOADS:
       // TODO(tapted): Prompt for downloading multiple files.
       break;
     case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
       // TODO(tapted): Prompt for quota request.
       break;
     case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
     case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA:
-      AddMediaRequest(manager, it->type);
+      if (base::FeatureList::IsEnabled(
+              features::kUsePermissionManagerForMediaRequests)) {
+        manager->AddRequest(MakePermissionRequest(it->type));
+      } else {
+        AddMediaRequest(manager, it->type);
+      }
       break;
     // Regular permissions requests.
     case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
     case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:  // Same as notifications.
     case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
     case CONTENT_SETTINGS_TYPE_GEOLOCATION:
     case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:  // ChromeOS only.
     case CONTENT_SETTINGS_TYPE_PPAPI_BROKER:
     case CONTENT_SETTINGS_TYPE_PLUGINS:  // Flash.
       manager->AddRequest(MakePermissionRequest(it->type));
       break;
     case CONTENT_SETTINGS_TYPE_DEFAULT:
       EXPECT_EQ(kMultipleName, name);
-      for (auto request : kMultipleRequests)
-        manager->AddRequest(MakePermissionRequest(request));
+      if (base::FeatureList::IsEnabled(
+              features::kUsePermissionManagerForMediaRequests)) {
+        for (auto request : kMultipleRequestsWithMedia)
+          manager->AddRequest(MakePermissionRequest(request));
+      } else {
+        for (auto request : kMultipleRequests)
+          manager->AddRequest(MakePermissionRequest(request));
+      }
+
       break;
     default:
       ADD_FAILURE() << "Not a permission type, or one that doesn't prompt.";
       return;
   }
   manager->DisplayPendingRequests();
 }
 
 // Requests before the load event should be bundled into one bubble.
 // http://crbug.com/512849 flaky
@@ skipping 184 matching lines @@
 }
 
 // Host wants to show notifications.
 IN_PROC_BROWSER_TEST_F(PermissionDialogTest, InvokeDialog_notifications) {
   RunDialog();
 }
 
 // Host wants to use your microphone.
 IN_PROC_BROWSER_TEST_F(PermissionDialogTest, InvokeDialog_mic) {
   RunDialog();
+
+  {
+    base::test::ScopedFeatureList scoped_feature_list;
+    scoped_feature_list.InitAndEnableFeature(
+        features::kUsePermissionManagerForMediaRequests);
+    RunDialog();
+  }
 }
 
 // Host wants to use your camera.
 IN_PROC_BROWSER_TEST_F(PermissionDialogTest, InvokeDialog_camera) {
   RunDialog();
+
+  {
+    base::test::ScopedFeatureList scoped_feature_list;
+    scoped_feature_list.InitAndEnableFeature(
+        features::kUsePermissionManagerForMediaRequests);
+    RunDialog();
+  }
 }
 
 // Host wants to open email links.
 IN_PROC_BROWSER_TEST_F(PermissionDialogTest, InvokeDialog_protocol_handlers) {
   RunDialog();
 }
 
 // Host wants to use your MIDI devices.
 IN_PROC_BROWSER_TEST_F(PermissionDialogTest, InvokeDialog_midi) {
   RunDialog();
 }
 
 // Shows a permissions bubble with multiple requests.
 IN_PROC_BROWSER_TEST_F(PermissionDialogTest, InvokeDialog_multiple) {
   RunDialog();
+
+  {
+    base::test::ScopedFeatureList scoped_feature_list;
+    scoped_feature_list.InitAndEnableFeature(
+        features::kUsePermissionManagerForMediaRequests);
+    RunDialog();
+  }
 }
 
 // CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER is ChromeOS only.
 #if defined(OS_CHROMEOS)
 #define MAYBE_InvokeDialog_protected_media InvokeDialog_protected_media
 #else
 #define MAYBE_InvokeDialog_protected_media DISABLED_InvokeDialog_protected_media
 #endif
 IN_PROC_BROWSER_TEST_F(PermissionDialogTest,
                        MAYBE_InvokeDialog_protected_media) {
   RunDialog();
 }
 
 }  // anonymous namespace