Fix VR Shell black screen during tests

Fix VR Shell black screen during tests

Forces VrShellDelegate's constructor to run on the main/UI thread, as
otherwise the Choreographer instance acquired in the constructor is for
the instrumentation thread during e2e tests, which breaks VR Shell.

BUG=707275
Review-Url: https://codereview.chromium.org/2838763002
Cr-Commit-Position: refs/heads/master@{#466990}
Committed: https://chromium.googlesource.com/chromium/src/+/53f787b5b82c2e4d3967bc09a803faae7ea42350

[bsheedy, 2017-04-24 21:39:56]

bsheedy@chromium.org changed reviewers:
+ mthiesse@chromium.org

[bsheedy, 2017-04-24 21:42:14]

The CQ bit was checked by bsheedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 21:42:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mthiesse, 2017-04-24 21:44:33]

https://codereview.chromium.org/2838763002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2838763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:278:
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
We shouldn't be doing this here. We should just assert in this function that
we're called from the UI thread, and the test code should do the blocking
running on another thread.

[bsheedy, 2017-04-24 22:37:56]

bsheedy@chromium.org changed reviewers:
+ skyostil@chromium.org

[bsheedy, 2017-04-24 22:37:56]

skyostil@chromium.org: Please review changes in chrome/android/javatests/

https://codereview.chromium.org/2838763002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2838763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:278:
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
On 2017/04/24 21:44:33, mthiesse wrote:
> We shouldn't be doing this here. We should just assert in this function that
> we're called from the UI thread, and the test code should do the blocking
> running on another thread.

Done.

[mthiesse, 2017-04-25 00:44:43]

lgtm

[Sami, 2017-04-25 11:22:57]

lgtm

[mthiesse, 2017-04-25 14:15:22]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2017-04-25 14:15:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 14:49:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493129722909040,
"parent_rev": "a0717ac57c2ce54ecf2ee0ed86a428a5d1566a77", "commit_rev":
"53f787b5b82c2e4d3967bc09a803faae7ea42350"}

[commit-bot: I haz the power, 2017-04-25 14:49:28]

Description was changed from

==========
Fix VR Shell black screen during tests

Forces VrShellDelegate's constructor to run on the main/UI thread, as
otherwise the Choreographer instance acquired in the constructor is for
the instrumentation thread during e2e tests, which breaks VR Shell.

BUG=707275
==========

to

==========
Fix VR Shell black screen during tests

Forces VrShellDelegate's constructor to run on the main/UI thread, as
otherwise the Choreographer instance acquired in the constructor is for
the instrumentation thread during e2e tests, which breaks VR Shell.

BUG=707275

Review-Url: https://codereview.chromium.org/2838763002
Cr-Commit-Position: refs/heads/master@{#466990}
Committed:
https://chromium.googlesource.com/chromium/src/+/53f787b5b82c2e4d3967bc09a803...
==========

[commit-bot: I haz the power, 2017-04-25 14:49:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53f787b5b82c2e4d3967bc09a803...