Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java

Issue 2838763002: Fix VR Shell black screen during tests (Closed)
Patch Set: Address mthiesse@ comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
index c95b75f6ffed76f6e0aaf72d8320344f7e634660..4c5a0616f5c1b2985990655be58c4da764986ce3 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
@@ -47,7 +47,16 @@ public class VrShellTest extends ChromeTabbedActivityTestBase {
@Override
protected void setUp() throws Exception {
super.setUp();
- mDelegate = VrShellDelegate.getInstanceForTesting();
+ // We need to run the constructor on the main/UI thread, otherwise the Choreographer
+ // acquired in the constructor is incorrect during e2e tests
+ final AtomicReference<VrShellDelegate> delegate = new AtomicReference<VrShellDelegate>();
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
+ public void run() {
+ delegate.set(VrShellDelegate.getInstanceForTesting());
+ }
+ });
+ mDelegate = delegate.get();
}
@Override
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698