Omnibox - Add about:flag to Enable Clipboard Provider

Omnibox - Add about:flag to Enable Clipboard Provider

BUG=714831
Review-Url: https://codereview.chromium.org/2838753003
Cr-Commit-Position: refs/heads/master@{#466897}
Committed: https://chromium.googlesource.com/chromium/src/+/5aed28a8dd240c55ec7521ee3fb3853a24ed4dcf

[Mark P, 2017-04-24 23:05:20]

mpearson@chromium.org changed reviewers:
+ pkasting@chromium.org

[Mark P, 2017-04-24 23:05:20]

Peter, can you please take a look?

thanks,
mark

[Mark P, 2017-04-24 23:05:26]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 23:06:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-04-24 23:09:54]

LGTM, but I'm not a big fan of surrounding each individual flag with #if
OS_ANDROID.  I sort of feel like we should either:
(1) Just remove the guards... kOsAndroid makes sure this is only enabled for the
correct platforms
(2) Combine all the OS_ANDROID flags into a single #ifdefed section

I don't care enough to force you to do anything, just consider it

[commit-bot: I haz the power, 2017-04-24 23:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:10:04]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mark P, 2017-04-25 04:14:42]

On 2017/04/24 23:09:54, Peter Kasting wrote:
> LGTM, but I'm not a big fan of surrounding each individual flag with #if
> OS_ANDROID.  I sort of feel like we should either:
> (1) Just remove the guards... kOsAndroid makes sure this is only enabled for
the
> correct platforms
> (2) Combine all the OS_ANDROID flags into a single #ifdefed section
> 
> I don't care enough to force you to do anything, just consider it

Considered.

I also don't particularly like the how the file is structured, but I can
understand the reasons for it and don't want to fit a battle to change the
style.

--mark

[Mark P, 2017-04-25 04:14:45]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2017-04-25 04:14:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2838753003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-25 04:15:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark P, 2017-04-25 04:59:49]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2017-04-25 04:59:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2838753003/#ps40001
(title: "add histograms.xml for the flags")

[commit-bot: I haz the power, 2017-04-25 05:00:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 06:01:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493096389315460,
"parent_rev": "1ed4a43703873eced52dae51c62682fef5cfd9b7", "commit_rev":
"5aed28a8dd240c55ec7521ee3fb3853a24ed4dcf"}

[commit-bot: I haz the power, 2017-04-25 06:02:36]

Description was changed from

==========
Omnibox - Add about:flag to Enable Clipboard Provider

BUG=714831
==========

to

==========
Omnibox - Add about:flag to Enable Clipboard Provider

BUG=714831

Review-Url: https://codereview.chromium.org/2838753003
Cr-Commit-Position: refs/heads/master@{#466897}
Committed:
https://chromium.googlesource.com/chromium/src/+/5aed28a8dd240c55ec7521ee3fb3...
==========

[commit-bot: I haz the power, 2017-04-25 06:02:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5aed28a8dd240c55ec7521ee3fb3...