Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2838753003: Omnibox - Add about:flag to Enable Clipboard Provider (Closed)
Patch Set: add histograms.xml for the flags Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2734 matching lines...) Expand 10 before | Expand all | Expand 10 after
2745 {"enable-webnfc", flag_descriptions::kEnableWebNfcName, 2745 {"enable-webnfc", flag_descriptions::kEnableWebNfcName,
2746 flag_descriptions::kEnableWebNfcDescription, kOsAndroid, 2746 flag_descriptions::kEnableWebNfcDescription, kOsAndroid,
2747 FEATURE_VALUE_TYPE(features::kWebNfc)}, 2747 FEATURE_VALUE_TYPE(features::kWebNfc)},
2748 #endif 2748 #endif
2749 2749
2750 {"enable-idle-time-spell-checking", 2750 {"enable-idle-time-spell-checking",
2751 flag_descriptions::kEnableIdleTimeSpellCheckingName, 2751 flag_descriptions::kEnableIdleTimeSpellCheckingName,
2752 flag_descriptions::kEnableIdleTimeSpellCheckingDescription, kOsAll, 2752 flag_descriptions::kEnableIdleTimeSpellCheckingDescription, kOsAll,
2753 FEATURE_VALUE_TYPE(features::kIdleTimeSpellChecking)}, 2753 FEATURE_VALUE_TYPE(features::kIdleTimeSpellChecking)},
2754 2754
2755 #if defined(OS_ANDROID)
2756 {"enable-clipboard-provider",
2757 flag_descriptions::kEnableOmniboxClipboardProviderName,
2758 flag_descriptions::kEnableOmniboxClipboardProviderDescription, kOsAndroid,
2759 FEATURE_VALUE_TYPE(omnibox::kEnableClipboardProvider)},
2760 #endif
2761
2755 // NOTE: Adding new command-line switches requires adding corresponding 2762 // NOTE: Adding new command-line switches requires adding corresponding
2756 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2763 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2757 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2764 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2758 }; 2765 };
2759 2766
2760 class FlagsStateSingleton { 2767 class FlagsStateSingleton {
2761 public: 2768 public:
2762 FlagsStateSingleton() 2769 FlagsStateSingleton()
2763 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2770 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2764 ~FlagsStateSingleton() {} 2771 ~FlagsStateSingleton() {}
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
2961 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2968 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2962 2969
2963 const FeatureEntry* GetFeatureEntries(size_t* count) { 2970 const FeatureEntry* GetFeatureEntries(size_t* count) {
2964 *count = arraysize(kFeatureEntries); 2971 *count = arraysize(kFeatureEntries);
2965 return kFeatureEntries; 2972 return kFeatureEntries;
2966 } 2973 }
2967 2974
2968 } // namespace testing 2975 } // namespace testing
2969 2976
2970 } // namespace about_flags 2977 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698