Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.

Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.

(Re-land after fix to avoid deleting nonexistent textures.)

Blitting from a multisampled RGB8 renderbuffer to an alpha:false WebGL
back buffer is supposed to work, and from an RGBA8 renderbuffer is
supposed to not work. The emulation of IOSurface-backed RGB textures
using RGBA textures didn't handle this case.

Add BindTexImage2DWithInternalformatCHROMIUM to the command buffer to
allow internal format to be overridden; currently this is only
supported on macOS. Use this to bind a second texture to the IOSurface
and use it only for BlitFramebuffer calls from WebGL, fixing up the
alpha channel afterward.

Covered by new conformance test in
https://github.com/KhronosGroup/WebGL/pull/2377 .

BUG=699566
TBR=zmo@chromium.org,ccameron@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2838743002
Cr-Commit-Position: refs/heads/master@{#466878}
Committed: https://chromium.googlesource.com/chromium/src/+/e90ed61ee27f039c110fea16425a723f82bdbaf9

[Ken Russell (switch to Gerrit), 2017-04-24 21:11:25]

Description was changed from

==========
Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.

(Re-land after fix to avoid deleting nonexistent textures.)

Blitting from a multisampled RGB8 renderbuffer to an alpha:false WebGL
back buffer is supposed to work, and from an RGBA8 renderbuffer is
supposed to not work. The emulation of IOSurface-backed RGB textures
using RGBA textures didn't handle this case.

Add BindTexImage2DWithInternalformatCHROMIUM to the command buffer to
allow internal format to be overridden; currently this is only
supported on macOS. Use this to bind a second texture to the IOSurface
and use it only for BlitFramebuffer calls from WebGL, fixing up the
alpha channel afterward.

Covered by new conformance test in
https://github.com/KhronosGroup/WebGL/pull/2377 .

BUG=699566
==========

to

==========
Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.

(Re-land after fix to avoid deleting nonexistent textures.)

Blitting from a multisampled RGB8 renderbuffer to an alpha:false WebGL
back buffer is supposed to work, and from an RGBA8 renderbuffer is
supposed to not work. The emulation of IOSurface-backed RGB textures
using RGBA textures didn't handle this case.

Add BindTexImage2DWithInternalformatCHROMIUM to the command buffer to
allow internal format to be overridden; currently this is only
supported on macOS. Use this to bind a second texture to the IOSurface
and use it only for BlitFramebuffer calls from WebGL, fixing up the
alpha channel afterward.

Covered by new conformance test in
https://github.com/KhronosGroup/WebGL/pull/2377 .

BUG=699566
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-04-25 01:42:22]

kbr@chromium.org changed reviewers:
+ ccameron@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2017-04-25 01:42:23]

zmo, ccameron: CQ'ing this re-land TBR'd because the fix for the underlying
assertion failure was trivial, and the command buffer client has been fixed in
http://crbug.com/714761 so that these sort of assertion failures won't slip past
the trybots again. (The mac_chromium_rel_ng tryjob for patch set 1 confirms this
is working.)

[Ken Russell (switch to Gerrit), 2017-04-25 01:42:41]

Description was changed from

==========
Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.

(Re-land after fix to avoid deleting nonexistent textures.)

Blitting from a multisampled RGB8 renderbuffer to an alpha:false WebGL
back buffer is supposed to work, and from an RGBA8 renderbuffer is
supposed to not work. The emulation of IOSurface-backed RGB textures
using RGBA textures didn't handle this case.

Add BindTexImage2DWithInternalformatCHROMIUM to the command buffer to
allow internal format to be overridden; currently this is only
supported on macOS. Use this to bind a second texture to the IOSurface
and use it only for BlitFramebuffer calls from WebGL, fixing up the
alpha channel afterward.

Covered by new conformance test in
https://github.com/KhronosGroup/WebGL/pull/2377 .

BUG=699566
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.

(Re-land after fix to avoid deleting nonexistent textures.)

Blitting from a multisampled RGB8 renderbuffer to an alpha:false WebGL
back buffer is supposed to work, and from an RGBA8 renderbuffer is
supposed to not work. The emulation of IOSurface-backed RGB textures
using RGBA textures didn't handle this case.

Add BindTexImage2DWithInternalformatCHROMIUM to the command buffer to
allow internal format to be overridden; currently this is only
supported on macOS. Use this to bind a second texture to the IOSurface
and use it only for BlitFramebuffer calls from WebGL, fixing up the
alpha channel afterward.

Covered by new conformance test in
https://github.com/KhronosGroup/WebGL/pull/2377 .

BUG=699566
TBR=zmo@chromium.org,ccameron@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-04-25 01:42:55]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-04-25 01:43:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 05:17:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493084575186020,
"parent_rev": "414a9028af64f0e8d7289b16e829d782f4591368", "commit_rev":
"e90ed61ee27f039c110fea16425a723f82bdbaf9"}

[commit-bot: I haz the power, 2017-04-25 05:18:18]

Description was changed from

==========
Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.

(Re-land after fix to avoid deleting nonexistent textures.)

Blitting from a multisampled RGB8 renderbuffer to an alpha:false WebGL
back buffer is supposed to work, and from an RGBA8 renderbuffer is
supposed to not work. The emulation of IOSurface-backed RGB textures
using RGBA textures didn't handle this case.

Add BindTexImage2DWithInternalformatCHROMIUM to the command buffer to
allow internal format to be overridden; currently this is only
supported on macOS. Use this to bind a second texture to the IOSurface
and use it only for BlitFramebuffer calls from WebGL, fixing up the
alpha channel afterward.

Covered by new conformance test in
https://github.com/KhronosGroup/WebGL/pull/2377 .

BUG=699566
TBR=zmo@chromium.org,ccameron@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.

(Re-land after fix to avoid deleting nonexistent textures.)

Blitting from a multisampled RGB8 renderbuffer to an alpha:false WebGL
back buffer is supposed to work, and from an RGBA8 renderbuffer is
supposed to not work. The emulation of IOSurface-backed RGB textures
using RGBA textures didn't handle this case.

Add BindTexImage2DWithInternalformatCHROMIUM to the command buffer to
allow internal format to be overridden; currently this is only
supported on macOS. Use this to bind a second texture to the IOSurface
and use it only for BlitFramebuffer calls from WebGL, fixing up the
alpha channel afterward.

Covered by new conformance test in
https://github.com/KhronosGroup/WebGL/pull/2377 .

BUG=699566
TBR=zmo@chromium.org,ccameron@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2838743002
Cr-Commit-Position: refs/heads/master@{#466878}
Committed:
https://chromium.googlesource.com/chromium/src/+/e90ed61ee27f039c110fea16425a...
==========

[commit-bot: I haz the power, 2017-04-25 05:18:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e90ed61ee27f039c110fea16425a...