Fix DocumentMarkerController::RemoveSpellingMarkersUnderWords

Fix DocumentMarkerController::RemoveSpellingMarkersUnderWords

The above mentioned function used to remove all markers, which is wrong.
This patch fixes it to remove only spelling and grammar markers.

BUG=713995
TEST=DocumentMarkerControllerTest.RemoveSpellingMarkersUnderWords

Review-Url: https://codereview.chromium.org/2838733002
Cr-Commit-Position: refs/heads/master@{#466860}
Committed: https://chromium.googlesource.com/chromium/src/+/5b0a6581e71557593b172fc1b53e229e7a78cfe2

[Xiaocheng, 2017-04-24 21:06:55]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 21:07:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-04-24 21:08:11]

Description was changed from

==========
Fix DocumentMarkerController::RemoveSpellingMarkersUnderWords

BUG=
==========

to

==========
Fix DocumentMarkerController::RemoveSpellingMarkersUnderWords

The above mentioned function used to remove all markers, which is wrong.
This patch fixes it to remove only spelling and grammar markers.

BUG=713995
TEST=DocumentMarkerControllerTest.RemoveSpellingMarkersUnderWords
==========

[Xiaocheng, 2017-04-24 21:08:30]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-04-24 21:08:30]

PTAL.

[commit-bot: I haz the power, 2017-04-24 22:49:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 22:49:48]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-04-25 01:32:54]

lgtm

https://codereview.chromium.org/2838733002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(left):

https://codereview.chromium.org/2838733002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:503:
if (removed_markers && type == DocumentMarker::kTextMatch)
Nice!

https://codereview.chromium.org/2838733002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2838733002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:494:
if (!node.IsTextNode())
Q: My understanding is all |Node| in |markers_| are |Text| node.
Can we make sure of this? Or let's find who put non-|Text| node into markers.
(in another patch, of course)

[yosin_UTC9, 2017-04-25 01:32:57]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-04-25 01:33:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 01:40:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493083977633300, "parent_rev":
"b59caf5ed8e6a88e01378209ebd477f921e65a6e", "commit_rev":
"5b0a6581e71557593b172fc1b53e229e7a78cfe2"}

[commit-bot: I haz the power, 2017-04-25 01:40:12]

Description was changed from

==========
Fix DocumentMarkerController::RemoveSpellingMarkersUnderWords

The above mentioned function used to remove all markers, which is wrong.
This patch fixes it to remove only spelling and grammar markers.

BUG=713995
TEST=DocumentMarkerControllerTest.RemoveSpellingMarkersUnderWords
==========

to

==========
Fix DocumentMarkerController::RemoveSpellingMarkersUnderWords

The above mentioned function used to remove all markers, which is wrong.
This patch fixes it to remove only spelling and grammar markers.

BUG=713995
TEST=DocumentMarkerControllerTest.RemoveSpellingMarkersUnderWords

Review-Url: https://codereview.chromium.org/2838733002
Cr-Commit-Position: refs/heads/master@{#466860}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b0a6581e71557593b172fc1b53e...
==========

[commit-bot: I haz the power, 2017-04-25 01:40:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b0a6581e71557593b172fc1b53e...