Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Issue 2838733002: Fix DocumentMarkerController::RemoveSpellingMarkersUnderWords (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
index 16646d479b6e9f8aeac26de431586f1ee39540ff..931f6e7b208f7af8e26bd48d29f342c413489220 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
@@ -324,4 +324,28 @@ TEST_F(DocumentMarkerControllerTest, RemoveEndOfMarker) {
EXPECT_EQ(0u, MarkerController().Markers().size());
}
+TEST_F(DocumentMarkerControllerTest, RemoveSpellingMarkersUnderWords) {
+ SetBodyInnerHTML("<div contenteditable>foo</div>");
+ GetDocument().UpdateStyleAndLayout();
+ Element* div = GetDocument().QuerySelector("div");
+ Node* text = div->firstChild();
+
+ // Add a spelling marker and a text match marker to "foo".
+ const EphemeralRange marker_range(Position(text, 0), Position(text, 3));
+ MarkerController().AddMarker(marker_range.StartPosition(),
+ marker_range.EndPosition(),
+ DocumentMarker::kSpelling, "");
+ MarkerController().AddTextMatchMarker(marker_range,
+ DocumentMarker::MatchStatus::kInactive);
+
+ MarkerController().RemoveSpellingMarkersUnderWords({"foo"});
+
+ // RemoveSpellingMarkersUnderWords does not remove text match marker.
+ ASSERT_EQ(1u, MarkerController().Markers().size());
+ const DocumentMarker& marker = *MarkerController().Markers()[0];
+ EXPECT_EQ(0u, marker.StartOffset());
+ EXPECT_EQ(3u, marker.EndOffset());
+ EXPECT_EQ(DocumentMarker::kTextMatch, marker.GetType());
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698