Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2838713003: [Doodle] Allow cookie authentication (Closed)

Created:
2 years, 1 month ago by Marc Treib
Modified:
2 years, 1 month ago
Reviewers:
fhorschig
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Doodle] Allow cookie authentication This enables birthday doodles. BUG=715154 Review-Url: https://codereview.chromium.org/2838713003 Cr-Commit-Position: refs/heads/master@{#467290} Committed: https://chromium.googlesource.com/chromium/src/+/29b3b5cf99713f88fd9b5739dcbb2f476e2721e0

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Patch Set 3 : review2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M components/doodle/doodle_fetcher_impl.cc View 1 2 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Marc Treib
2 years, 1 month ago (2017-04-26 08:00:25 UTC) #6
Marc Treib
+rhalavati FYI
2 years, 1 month ago (2017-04-26 08:03:40 UTC) #7
fhorschig
lgtm w/ nit https://codereview.chromium.org/2838713003/diff/1/components/doodle/doodle_fetcher_impl.cc File components/doodle/doodle_fetcher_impl.cc (right): https://codereview.chromium.org/2838713003/diff/1/components/doodle/doodle_fetcher_impl.cc#newcode92 components/doodle/doodle_fetcher_impl.cc:92: "appropriate times." nit: pretty hard to ...
2 years, 1 month ago (2017-04-26 08:08:53 UTC) #8
Marc Treib
https://codereview.chromium.org/2838713003/diff/1/components/doodle/doodle_fetcher_impl.cc File components/doodle/doodle_fetcher_impl.cc (right): https://codereview.chromium.org/2838713003/diff/1/components/doodle/doodle_fetcher_impl.cc#newcode92 components/doodle/doodle_fetcher_impl.cc:92: "appropriate times." On 2017/04/26 08:08:53, fhorschig wrote: > nit: ...
2 years, 1 month ago (2017-04-26 08:32:00 UTC) #10
Ramin Halavati
On 2017/04/26 08:32:00, Marc Treib wrote: > https://codereview.chromium.org/2838713003/diff/1/components/doodle/doodle_fetcher_impl.cc > File components/doodle/doodle_fetcher_impl.cc (right): > > https://codereview.chromium.org/2838713003/diff/1/components/doodle/doodle_fetcher_impl.cc#newcode92 ...
2 years, 1 month ago (2017-04-26 09:13:05 UTC) #12
Marc Treib
On 2017/04/26 09:13:05, Ramin Halavati wrote: > On 2017/04/26 08:32:00, Marc Treib wrote: > > ...
2 years, 1 month ago (2017-04-26 09:27:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838713003/40001
2 years, 1 month ago (2017-04-26 10:27:31 UTC) #20
commit-bot: I haz the power
2 years, 1 month ago (2017-04-26 10:32:45 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/29b3b5cf99713f88fd9b5739dcbb...

Powered by Google App Engine
This is Rietveld 408576698