[Doodle] Allow cookie authentication

components/doodle/doodle_fetcher_impl.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/doodle/doodle_fetcher_impl.h"
 
 #include <utility>
 
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
@@ skipping 69 matching lines @@
   callbacks_.push_back(std::move(callback));
   net::NetworkTrafficAnnotationTag traffic_annotation =
       net::DefineNetworkTrafficAnnotation("doodle_fetcher", R"(
         semantics {
           sender: "Doodle Fetcher"
           description:
             "Retrieves metadata (image URL, clickthrough URL etc) for any "
             "currently running Doodle."
           trigger:
             "Displaying the new tab page on Android."
-          data: "None."
+          data:
+            "The user's Google cookies to show for example birthday doodles at "
+            "appropriate times."

[fhorschig, 2017/04/26 08:08:53]

nit: pretty hard to read. How about:

The user's Google cookies. Used [for example] to show birthday doodles at
appropriate times.

... is there any other use case than birthday doodles?
If not, drop the [for example].

[Marc Treib, 2017/04/26 08:32:00]

Done.
I'm not aware of any other use case, but a) it's hard to be sure, and b) it
might change in the future, and when that happens, this string will almost
certainly not get updated. So I'd like to leave a bit of wiggle room.

           destination: GOOGLE_OWNED_SERVICE
         }
         policy {
-          cookies_allowed: false
+          cookies_allowed: true
           setting:
             "Choosing a non-Google search engine in Chromium settings under "
             "'Search Engine' will disable this feature."
           policy_exception_justification:
             "Not implemented, considered not useful as it does not upload any "
             "data."
         })");
   fetcher_ = URLFetcher::Create(
       BuildDoodleURL(GetGoogleBaseUrl(), gray_background_, override_url_),
       URLFetcher::GET, this, traffic_annotation);
   fetcher_->SetRequestContext(download_context_.get());
-  fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
-                         net::LOAD_DO_NOT_SAVE_COOKIES |
-                         net::LOAD_DO_NOT_SEND_AUTH_DATA);
+  // TODO(treib): Use OAuth2 authentication instead of cookies. crbug.com/711314
+  fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_AUTH_DATA);
   fetcher_->SetAutomaticallyRetryOnNetworkChanges(1);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher_.get(), data_use_measurement::DataUseUserData::DOODLE);
   fetcher_->Start();
 }
 
 void DoodleFetcherImpl::OnURLFetchComplete(const URLFetcher* source) {
   DCHECK_EQ(fetcher_.get(), source);
   std::unique_ptr<net::URLFetcher> free_fetcher = std::move(fetcher_);
 
@@ skipping 79 matching lines @@
 
 GURL DoodleFetcherImpl::GetGoogleBaseUrl() const {
   GURL cmd_line_url = google_util::CommandLineGoogleBaseURL();
   if (cmd_line_url.is_valid()) {
     return cmd_line_url;
   }
   return google_url_tracker_->google_url();
 }
 
 }  // namespace doodle