Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2838673004: win: /PROFILE works fine with clang. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews, Reid Kleckner, Sébastien Marchand
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

win: /PROFILE works fine with clang. BUG=82385 Review-Url: https://codereview.chromium.org/2838673004 Cr-Commit-Position: refs/heads/master@{#467126} Committed: https://chromium.googlesource.com/chromium/src/+/5aabe7f1511ffb880612b9ec8e43fe3f7950e14a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/win/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
Sounds like nobody knows why this was here, and Seb says things build fine for ...
3 years, 8 months ago (2017-04-25 20:27:48 UTC) #3
hans
lgtm
3 years, 8 months ago (2017-04-25 20:32:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838673004/1
3 years, 8 months ago (2017-04-25 20:55:24 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 21:48:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5aabe7f1511ffb880612b9ec8e43...

Powered by Google App Engine
This is Rietveld 408576698