Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Unified Diff: build/config/win/BUILD.gn

Issue 2838673004: win: /PROFILE works fine with clang. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index 215631366dac71b884c0583a7e93c18b53ac5772..69867ecea3d0c95922cc314e53b3f4419b043978 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -86,13 +86,13 @@ config("compiler") {
# information is used by the Syzygy optimization tool when decomposing the
# release image. It is enabled for syzyasan builds and opportunistically for
# other builds where it is not prohibited (not supported when incrementally
- # linking, using /debug:fastlink, or building with clang).
+ # linking, or using /debug:fastlink).
if (is_syzyasan) {
assert(!is_win_fastlink)
ldflags = [ "/PROFILE" ]
} else {
if (!is_debug && !is_component_build) {
- if (is_win_fastlink || is_clang) {
+ if (is_win_fastlink) {
# /PROFILE implies the following linker flags. Therefore if we are
# skipping /PROFILE because it is incompatible with /DEBUG:FASTLINK
# we should explicitly add these flags in order to avoid unintended
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698