Added Setters to NavigationContextImpl.

Added Setters to NavigationContextImpl.

This CL (5 of 7) is a part of large refactoring to create
NavigationContext when navigation was started, not when it is finished.
This refactoring will allow to pass the same instance of
NavigationContext to DidStartNavigation and DidFinishNavigation
(crbug.com/713836). Also this will allow to associate NavigationItem
with NavigationContext object to commit non-latest navigation
(crbug.com/712269).

This CL adds setters to NavigationContextImpl, which will be created only with
web state and URL and will be configured via setters before committing.

BUG=713836, 712269
Review-Url: https://codereview.chromium.org/2838583002
Cr-Commit-Position: refs/heads/master@{#470372}
Committed: https://chromium.googlesource.com/chromium/src/+/c6a32ecf073cb1616e51c927b2bfdad46a539c31

[Eugene But (OOO till 7-30), 2017-04-24 12:43:06]

Description was changed from

==========
Added Setters to NavigationContextImpl.

This CL (5 of 7) is a part of large refactoring to create NavigationContext
when navigation was started, not when it is finished. This refactoring will
allow to pass the same instance of NavigationContext to DidStartNavigation and
DidFinishNavigation (crbug.com/713836). Also this will allow to associate
NavigationItem with NavigationContext object to commit non-latest navigation
(crbug.com/712269).


BUG=713836, 712269
==========

to

==========
Added Setters to NavigationContextImpl.

This CL (5 of 7) is a part of large refactoring to create NavigationContext
when navigation was started, not when it is finished. This refactoring will
allow to pass the same instance of NavigationContext to DidStartNavigation and
DidFinishNavigation (crbug.com/713836). Also this will allow to associate
NavigationItem with NavigationContext object to commit non-latest navigation
(crbug.com/712269).

This CL adds setters to NavigationContextImpl, which will be created only with
web state and URL and will be configured via setters before committing.

BUG=713836, 712269
==========

[Eugene But (OOO till 7-30), 2017-04-24 12:52:57]

Description was changed from

==========
Added Setters to NavigationContextImpl.

This CL (5 of 7) is a part of large refactoring to create NavigationContext
when navigation was started, not when it is finished. This refactoring will
allow to pass the same instance of NavigationContext to DidStartNavigation and
DidFinishNavigation (crbug.com/713836). Also this will allow to associate
NavigationItem with NavigationContext object to commit non-latest navigation
(crbug.com/712269).

This CL adds setters to NavigationContextImpl, which will be created only with
web state and URL and will be configured via setters before committing.

BUG=713836, 712269
==========

to

==========
Added Setters to NavigationContextImpl.

This CL (5 of 7) is a part of large refactoring to create
NavigationContext when navigation was started, not when it is finished.
This refactoring will allow to pass the same instance of
NavigationContext to DidStartNavigation and DidFinishNavigation
(crbug.com/713836). Also this will allow to associate NavigationItem
with NavigationContext object to commit non-latest navigation
(crbug.com/712269).

This CL adds setters to NavigationContextImpl, which will be created only with
web state and URL and will be configured via setters before committing.

BUG=713836, 712269
==========

[Eugene But (OOO till 7-30), 2017-04-24 14:05:10]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[kkhorimoto, 2017-04-25 13:53:26]

https://codereview.chromium.org/2838583002/diff/1/ios/web/web_state/navigatio...
File ios/web/web_state/navigation_context_impl.h (right):

https://codereview.chromium.org/2838583002/diff/1/ios/web/web_state/navigatio...
ios/web/web_state/navigation_context_impl.h:26: // Creates navigation context
for sucessful navigation to a different page.
Do you want to mention that this factory method is deprecated now?  Your test
rename seems to indicate that's the case.

https://codereview.chromium.org/2838583002/diff/1/ios/web/web_state/navigatio...
ios/web/web_state/navigation_context_impl.h:57: void SetIsSameDocument(bool
is_same_document);
Do we need to expose a setter for IsSameDocument?  I can see why a normal
NavigationContext might become an error page after some kind of navigation
error, but it doesn't seem possible that a same document navigation becomes a
different-document navigation.

[Eugene But (OOO till 7-30), 2017-04-27 12:19:00]

https://codereview.chromium.org/2838583002/diff/1/ios/web/web_state/navigatio...
File ios/web/web_state/navigation_context_impl.h (right):

https://codereview.chromium.org/2838583002/diff/1/ios/web/web_state/navigatio...
ios/web/web_state/navigation_context_impl.h:26: // Creates navigation context
for sucessful navigation to a different page.
On 2017/04/25 13:53:26, kkhorimoto_ wrote:
> Do you want to mention that this factory method is deprecated now?  Your test
> rename seems to indicate that's the case.
I'll just remove them in this CL:
https://codereview.chromium.org/2845913003/

https://codereview.chromium.org/2838583002/diff/1/ios/web/web_state/navigatio...
ios/web/web_state/navigation_context_impl.h:57: void SetIsSameDocument(bool
is_same_document);
On 2017/04/25 13:53:25, kkhorimoto_ wrote:
> Do we need to expose a setter for IsSameDocument?  I can see why a normal
> NavigationContext might become an error page after some kind of navigation
> error, but it doesn't seem possible that a same document navigation becomes a
> different-document navigation.
This is needed for user-initiated fragment change navigations (when user types
in the the url which is the same, but has a different fragment). Also having
setter is generally consistent with the rest of the code.

[kkhorimoto, 2017-05-01 23:03:52]

lgtm

[Eugene But (OOO till 7-30), 2017-05-09 17:17:34]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-05-09 17:17:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkhorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2838583002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2017-05-09 17:18:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 17:39:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494350254643050,
"parent_rev": "84d8af49b69b6ab89bde2d657b96c5f280fd439c", "commit_rev":
"c6a32ecf073cb1616e51c927b2bfdad46a539c31"}

[commit-bot: I haz the power, 2017-05-09 17:39:31]

Description was changed from

==========
Added Setters to NavigationContextImpl.

This CL (5 of 7) is a part of large refactoring to create
NavigationContext when navigation was started, not when it is finished.
This refactoring will allow to pass the same instance of
NavigationContext to DidStartNavigation and DidFinishNavigation
(crbug.com/713836). Also this will allow to associate NavigationItem
with NavigationContext object to commit non-latest navigation
(crbug.com/712269).

This CL adds setters to NavigationContextImpl, which will be created only with
web state and URL and will be configured via setters before committing.

BUG=713836, 712269
==========

to

==========
Added Setters to NavigationContextImpl.

This CL (5 of 7) is a part of large refactoring to create
NavigationContext when navigation was started, not when it is finished.
This refactoring will allow to pass the same instance of
NavigationContext to DidStartNavigation and DidFinishNavigation
(crbug.com/713836). Also this will allow to associate NavigationItem
with NavigationContext object to commit non-latest navigation
(crbug.com/712269).

This CL adds setters to NavigationContextImpl, which will be created only with
web state and URL and will be configured via setters before committing.

BUG=713836, 712269

Review-Url: https://codereview.chromium.org/2838583002
Cr-Commit-Position: refs/heads/master@{#470372}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6a32ecf073cb1616e51c927b2bf...
==========

[commit-bot: I haz the power, 2017-05-09 17:39:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c6a32ecf073cb1616e51c927b2bf...