Added Setters to NavigationContextImpl.

ios/web/web_state/navigation_context_impl.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_WEB_STATE_NAVIGATION_CONTEXT_IMPL_H_
 #define IOS_WEB_WEB_STATE_NAVIGATION_CONTEXT_IMPL_H_
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "ios/web/public/web_state/navigation_context.h"
 #include "url/gurl.h"
 
 namespace web {
 
 // Tracks information related to a single navigation.
 class NavigationContextImpl : public NavigationContext {
  public:
   // Creates navigation context for sucessful navigation to a different page.
+  // Response headers will ne null.
+  static std::unique_ptr<NavigationContextImpl> CreateNavigationContext(
+      WebState* web_state,
+      const GURL& url);
+
+  // Creates navigation context for sucessful navigation to a different page.

[kkhorimoto, 2017/04/25 13:53:26]

Do you want to mention that this factory method is deprecated now?  Your test
rename seems to indicate that's the case.

[Eugene But (OOO till 7-30), 2017/04/27 12:18:59]

I'll just remove them in this CL:
https://codereview.chromium.org/2845913003/

   static std::unique_ptr<NavigationContextImpl> CreateNavigationContext(
       WebState* web_state,
       const GURL& url,
       const scoped_refptr<net::HttpResponseHeaders>& response_headers);
 
   // Creates navigation context for sucessful same page navigation.
   static std::unique_ptr<NavigationContextImpl>
   CreateSameDocumentNavigationContext(WebState* web_state, const GURL& url);
 
   // Creates navigation context for the error page navigation.
   static std::unique_ptr<NavigationContextImpl>
   CreateErrorPageNavigationContext(
       WebState* web_state,
       const GURL& url,
       const scoped_refptr<net::HttpResponseHeaders>& response_headers);
 
 #ifndef NDEBUG
   // Returns human readable description of this object.
   NSString* GetDescription() const;
 #endif  // NDEBUG
 
   // NavigationContext overrides:
   WebState* GetWebState() override;
   const GURL& GetUrl() const override;
   bool IsSameDocument() const override;
   bool IsErrorPage() const override;
   net::HttpResponseHeaders* GetResponseHeaders() const override;
   ~NavigationContextImpl() override;
 
+  // Setters for navigation context data members.
+  void SetIsSameDocument(bool is_same_document);

[kkhorimoto, 2017/04/25 13:53:25]

Do we need to expose a setter for IsSameDocument?  I can see why a normal
NavigationContext might become an error page after some kind of navigation
error, but it doesn't seem possible that a same document navigation becomes a
different-document navigation.

[Eugene But (OOO till 7-30), 2017/04/27 12:18:59]

This is needed for user-initiated fragment change navigations (when user types
in the the url which is the same, but has a different fragment). Also having
setter is generally consistent with the rest of the code.

+  void SetIsErrorPage(bool is_error_page);
+  void SetResponseHeaders(
+      const scoped_refptr<net::HttpResponseHeaders>& response_headers);
+
  private:
   NavigationContextImpl(
       WebState* web_state,
       const GURL& url,
       bool is_same_page,
       bool is_error_page,
       const scoped_refptr<net::HttpResponseHeaders>& response_headers);
 
   WebState* web_state_ = nullptr;
   GURL url_;
   bool is_same_document_ = false;
   bool is_error_page_ = false;
   scoped_refptr<net::HttpResponseHeaders> response_headers_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationContextImpl);
 };
 
 }  // namespace web
 
 #endif  // IOS_WEB_WEB_STATE_NAVIGATION_CONTEXT_IMPL_H_