Issue 2838563002: Use notification type to detect progress notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2838563002: Use notification type to detect progress notifications (Closed)

Created:
3 years, 8 months ago by Miguel Garcia

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Use notification type to detect progress notifications BUG=714029 Review-Url: https://codereview.chromium.org/2818373004 Cr-Commit-Position: refs/heads/master@{#465225} (cherry picked from commit df7bcad619555a798f21fa9ab52c81204cbb6315) Review-Url: https://codereview.chromium.org/2838563002 . Cr-Commit-Position: refs/branch-heads/3071@{#158} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c85518e8978da444d30b4eeda37e6c26a7657525

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/notifications/notification_platform_bridge_mac.mm	View		3 chunks	+4 lines, -2 lines	0 comments	Download
	M	chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Miguel Garcia

3 years, 8 months ago (2017-04-24 09:45:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c85518e8978da444d30b4eeda37e6c26a7657525.