Use notification type to detect progress notifications

Use notification type to detect progress notifications

BUG=

Review-Url: https://codereview.chromium.org/2818373004
Cr-Commit-Position: refs/heads/master@{#465225}
Committed: https://chromium.googlesource.com/chromium/src/+/df7bcad619555a798f21fa9ab52c81204cbb6315

[Miguel Garcia, 2017-04-18 12:59:26]

The CQ bit was checked by miguelg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 12:59:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 13:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 13:28:13]

Dry run: This issue passed the CQ dry run.

[Miguel Garcia, 2017-04-18 13:38:33]

miguelg@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-04-18 13:40:09]

lgtm % comment

https://codereview.chromium.org/2818373004/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac.mm (right):

https://codereview.chromium.org/2818373004/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:259:
notification.type() == message_center::NOTIFICATION_TYPE_PROGRESS) {
Presumably we should use this for prefixing the title too?

[Miguel Garcia, 2017-04-18 13:50:01]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2017-04-18 13:50:02]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2818373004/#ps20001
(title: "review")

[Miguel Garcia, 2017-04-18 13:50:25]

https://codereview.chromium.org/2818373004/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac.mm (right):

https://codereview.chromium.org/2818373004/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:259:
notification.type() == message_center::NOTIFICATION_TYPE_PROGRESS) {
On 2017/04/18 13:40:09, Peter Beverloo wrote:
> Presumably we should use this for prefixing the title too?

Done.

[commit-bot: I haz the power, 2017-04-18 13:50:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 14:17:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492523401991460,
"parent_rev": "51a85e6489c352e2fe29dd1075a9bf7142a3b828", "commit_rev":
"df7bcad619555a798f21fa9ab52c81204cbb6315"}

[commit-bot: I haz the power, 2017-04-18 14:18:09]

Description was changed from

==========
Use notification type to detect progress notifications

BUG=
==========

to

==========
Use notification type to detect progress notifications

BUG=

Review-Url: https://codereview.chromium.org/2818373004
Cr-Commit-Position: refs/heads/master@{#465225}
Committed:
https://chromium.googlesource.com/chromium/src/+/df7bcad619555a798f21fa9ab52c...
==========

[commit-bot: I haz the power, 2017-04-18 14:18:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/df7bcad619555a798f21fa9ab52c...