Issue 2838413002: Disable unused skia icons for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2838413002: Disable unused skia icons for Android. (Closed)

Created:
3 years, 8 months ago by mthiesse

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Disable unused skia icons for Android. We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out. This saves ~12KB in debug MonochromePublic builds. BUG=715192 Review-Url: https://codereview.chromium.org/2844513003 Cr-Commit-Position: refs/heads/master@{#467236} (cherry picked from commit 325ab947264549023c35565ca71fd5873a3d18c0) Review-Url: https://codereview.chromium.org/2838413002 . Cr-Commit-Position: refs/branch-heads/3071@{#224} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/259842d455b818e38f89a5a87d0ea0c6bcf04ee7

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -25 lines)			Patch
	M	ui/vector_icons/BUILD.gn	View		1 chunk	+27 lines, -25 lines	0 comments	Download

Total messages: 2 (1 generated)

mthiesse

3 years, 8 months ago (2017-04-26 14:17:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
259842d455b818e38f89a5a87d0ea0c6bcf04ee7.