Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 2838313003: Revert of 🏠 Polish bottom sheet content transitions (Closed)

Created:
2 years, 1 month ago by perezju
Modified:
2 years, 1 month ago
Reviewers:
mdjones, Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🏠 Polish bottom sheet content transitions (patchset #1 id:1 of https://codereview.chromium.org/2839673002/ ) Reason for revert: Appears to be causing multiple chrome_public_test_apk failures on Marshmallow 64 bit Tester. crbug.com/715336 Original issue's description: > [Home] Polish bottom sheet content transitions > > This change adds animation when transitioning between bottom sheet > content. The existing view is faded out completely before the new > view is faded in. The animation is applied to both the sheet content > and the toolbar view. > > Notably, the onContentChanged() event is now called when the > transition animation has finished instead of immediately when > showContent(...) is called. > > BUG=702717 > > Review-Url: https://codereview.chromium.org/2839673002 > Cr-Commit-Position: refs/heads/master@{#466780} > Committed: https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56daf75e5c2f0c TBR=twellington@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702717 Review-Url: https://codereview.chromium.org/2838313003 Cr-Commit-Position: refs/heads/master@{#467301} Committed: https://chromium.googlesource.com/chromium/src/+/a02c005fd02bcee2b11422d525db8370e473cbf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -83 lines) Patch
M chrome/android/java/res/layout/bottom_control_container.xml View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java View 7 chunks +69 lines, -79 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
perezju
Created Revert of 🏠 Polish bottom sheet content transitions
2 years, 1 month ago (2017-04-26 11:13:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838313003/1
2 years, 1 month ago (2017-04-26 11:13:39 UTC) #3
commit-bot: I haz the power
2 years, 1 month ago (2017-04-26 11:54:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a02c005fd02bcee2b11422d525db...

Powered by Google App Engine
This is Rietveld 408576698