gn: Address some TODO(GYP)s in the toplevel BUILD.gn

gn: Address some TODO(GYP)s in the toplevel BUILD.gn

No intended behavior change.

BUG=none

Review-Url: https://codereview.chromium.org/2838203003
Cr-Commit-Position: refs/heads/master@{#467139}
Committed: https://chromium.googlesource.com/chromium/src/+/75b3b45a4797bd19d3acea459082dd4914b2b07e

[Nico, 2017-04-25 20:43:43]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 20:44:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-04-25 20:45:41]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org

[Nico, 2017-04-25 20:45:42]

There's lots more of cleanups in here, but these are some the easy ones.

https://codereview.chromium.org/2838203003/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2838203003/diff/1/BUILD.gn#oldcode43
BUILD.gn:43: # "both_gn_and_gyp" should list every root target (target that
nothing else
This target no longer exists.

https://codereview.chromium.org/2838203003/diff/1/BUILD.gn#oldcode49
BUILD.gn:49: # "gn_only" should list every root target that is *not* intended to
be built in
Neither does this.

https://codereview.chromium.org/2838203003/diff/1/BUILD.gn#oldcode159
BUILD.gn:159: # and whether there should be other targets that are iOS-only and
missing.
This list of non-iOS targets looks roughly correct to me, so I declare this as
done.

https://codereview.chromium.org/2838203003/diff/1/BUILD.gn#oldcode550
BUILD.gn:550: "//net:net_unittests",  # TODO(GYP)
They both build fine on Windows.

https://codereview.chromium.org/2838203003/diff/1/BUILD.gn#oldcode835
BUILD.gn:835: "//services:service_unittests",
All these are depended on without this target already.

[Dirk Pranke, 2017-04-25 21:41:58]

lgtm, thanks for the cleanup!

[Nico, 2017-04-25 21:50:46]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-04-25 21:50:50]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:51:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:27:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493157050039860, "parent_rev":
"8f383ab372f040a216b3ff4f9afdb79da10d961c", "commit_rev":
"75b3b45a4797bd19d3acea459082dd4914b2b07e"}

[commit-bot: I haz the power, 2017-04-25 22:27:49]

Description was changed from

==========
gn: Address some TODO(GYP)s in the toplevel BUILD.gn

No intended behavior change.

BUG=none
==========

to

==========
gn: Address some TODO(GYP)s in the toplevel BUILD.gn

No intended behavior change.

BUG=none

Review-Url: https://codereview.chromium.org/2838203003
Cr-Commit-Position: refs/heads/master@{#467139}
Committed:
https://chromium.googlesource.com/chromium/src/+/75b3b45a4797bd19d3acea459082...
==========

[commit-bot: I haz the power, 2017-04-25 22:27:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75b3b45a4797bd19d3acea459082...