Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2838203003: gn: Address some TODO(GYP)s in the toplevel BUILD.gn (Closed)

Created:
2 years, 7 months ago by Nico
Modified:
2 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Address some TODO(GYP)s in the toplevel BUILD.gn No intended behavior change. BUG=none Review-Url: https://codereview.chromium.org/2838203003 Cr-Commit-Position: refs/heads/master@{#467139} Committed: https://chromium.googlesource.com/chromium/src/+/75b3b45a4797bd19d3acea459082dd4914b2b07e

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -31 lines) Patch
M BUILD.gn View 6 chunks +3 lines, -31 lines 5 comments Download

Messages

Total messages: 11 (7 generated)
Nico
There's lots more of cleanups in here, but these are some the easy ones. https://codereview.chromium.org/2838203003/diff/1/BUILD.gn ...
2 years, 7 months ago (2017-04-25 20:45:42 UTC) #4
Dirk Pranke
lgtm, thanks for the cleanup!
2 years, 7 months ago (2017-04-25 21:41:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838203003/1
2 years, 7 months ago (2017-04-25 21:51:27 UTC) #8
commit-bot: I haz the power
2 years, 7 months ago (2017-04-25 22:27:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75b3b45a4797bd19d3acea459082...

Powered by Google App Engine
This is Rietveld 408576698