gn: Address some TODO(GYP)s in the toplevel BUILD.gn

BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is the root build file for GN. GN will start processing by loading this
 # file, and recursively load all dependencies until all dependencies are either
 # resolved or known not to exist (which will cause the build to fail). So if
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
@@ skipping 20 matching lines @@
   # in files.
   root_extra_deps = []
 }
 
 if (is_official_build) {
   # An official (maximally optimized!) component (optimized for build times)
   # build doesn't make sense and usually doesn't work.
   assert(!is_component_build)
 }
 
-# This file defines the following five main targets:
-#
-# "both_gn_and_gyp" should list every root target (target that nothing else

[Nico, 2017/04/25 20:45:42]

This target no longer exists.

-# depends on) built by GN that is also built in the GYP build.
+# This file defines the following three main targets:
 #
 # "gn_all" should (transitively) cause everything to be built; if you run
 # 'ninja gn_all' and then 'ninja all', the second build should do no work.
 #
-# "gn_only" should list every root target that is *not* intended to be built in

[Nico, 2017/04/25 20:45:42]

Neither does this.

-# a GYP build. Because GN has different rules for deciding what an 'all' build
-# is, this may end up including targets that are actually defined in a GYP
-# build but not dependencies of GYP's "all" (and so not actually built).
-#
 # "gn_visibility": targets that are normally not visible to top-level targets,
 # but are built anyway by "all". Since we don't want any such targets, we have
 # this placeholder to make sure hidden targets that aren't otherwise depended
 # on yet are accounted for.
 #
 # "All" is an alias for "gn_all". It exists for bot compatibility w/ GYP for
 # the iOS bots and the official builders, but should not be generally used
 # during the GYP->GN migration.  We cannot guarantee that GN's "All" builds the
 # same set of targets as GYP's "All" does, because GYP's "All" supports
 # wildcards.
 #
 # Lastly, none of these targets are guaranteed to be the same as what ninja
-# will build with "all". For more on how "all" works and the differences in how
-# GYP and GN determine "all", see crbug.com/503241.
+# will build with "all". For more on how "all" works and how GN determines
+# "all", see crbug.com/503241.
 #
 # TODO(GYP_GONE): crbug.com/481694. Make sure that the above is true and there
 # are scripts run on the bots that enforce this. Once the GYP migration is
 # over, we can collapse all of these targets as desired.
 
 group("gn_all") {
   testonly = true
 
   deps = [
     ":gn_visibility",
@@ skipping 70 matching lines @@
       "//tools/gn",
       "//tools/gn:gn_unittests",
       "//tools/perf/clear_system_cache",
       "//tools/traffic_annotation/auditor:traffic_annotation_auditor",
       "//ui/accessibility:accessibility_unittests",
       "//ui/accessibility/extensions",
     ]
   }
 
   if (!is_ios) {
-    # TODO(GYP): Figure out which of these should actually build on iOS,
-    # and whether there should be other targets that are iOS-only and missing.

[Nico, 2017/04/25 20:45:42]

This list of non-iOS targets looks roughly correct to me, so I declare this as
done.

     deps += [
       "//cc:cc_unittests",
       "//chrome/test:telemetry_perf_unittests",
       "//chrome/test:unit_tests",
       "//components:components_browsertests",
       "//components/policy:policy_templates",
       "//content/shell:content_shell",
       "//content/test:content_browsertests",
       "//content/test:content_perftests",
       "//content/test:content_unittests",
@@ skipping 368 matching lines @@
       "//sandbox/win:pocdll",
       "//sandbox/win:sandbox_poc",
       "//sandbox/win:sbox_integration_tests",
       "//sandbox/win:sbox_unittests",
       "//sandbox/win:sbox_validation_tests",
       "//testing/gtest:gtest_main",
       "//third_party/pdfium/samples:pdfium_diff",
       "//third_party/tcmalloc:addr2line-pdb",
       "//tools/win/chromeexts:chromeexts",
     ]
-    deps -= [
-      "//crypto:crypto_unittests",  # TODO(GYP)
-      "//net:net_unittests",  # TODO(GYP)

[Nico, 2017/04/25 20:45:42]

They both build fine on Windows.

-    ]
 
     if (!(is_component_build && is_debug && target_cpu == "x86")) {
       deps +=
           [ "//chrome/installer/mini_installer:next_version_mini_installer" ]
     }
   } else if (!is_android && !is_ios) {
     deps += [ "//breakpad:symupload($host_toolchain)" ]
   }
 
   if (is_chromecast) {
@@ skipping 52 matching lines @@
 
     if (use_ozone && is_chromeos) {
       deps += [ "//services/ui/display:display_service_unittests" ]
     }
   }
 
   if (is_linux && !is_chromeos && !is_chromecast) {
     # TODO(GYP): Figure out if any of these should be in gn_all
     # and figure out how cross-platform they are
     deps += [
-      ":gn_mojo_targets",
       "//chrome/installer/util:strings",
       "//chrome/tools/convert_dict",
       "//components/constrained_window:unit_tests",
       "//components/filesystem:filesystem_service_unittests",
       "//components/leveldb:leveldb_service_unittests",
       "//components/metrics:serialization",
       "//components/password_manager/content/renderer:browser_tests",
       "//components/rappor:unit_tests",
       "//components/sessions:unit_tests",
       "//media/blink:media_blink_unittests",
@@ skipping 182 matching lines @@
       "//sandbox/linux:chrome_sandbox",
       "//sandbox/linux:sandbox_linux_unittests",
 
       # Blocked on https://github.com/catapult-project/catapult/issues/2297
       #"//third_party/catapult/telemetry:bitmaptools",
       "//tools/perf/clear_system_cache",
     ]
   }
 }
 
-group("gn_mojo_targets") {
-  testonly = true
-  if (is_linux && !is_chromeos) {
-    # TODO(GYP): Figure out if any of these should be in gn_all
-    # and figure out how cross-platform they are
-    deps = [
-      "//ipc:ipc_tests",
-      "//mojo:tests",
-      "//services:service_unittests",

[Nico, 2017/04/25 20:45:42]

All these are depended on without this target already.

-    ]
-  }
-}
-
 group("gn_visibility") {
   deps = [
     "//build/config/sanitizers:options_sources",
     # "//third_party/pdfium:pdfium_embeddertests",  # TODO(GYP): visibility?
     # "//third_party/pdfium:pdfium_unittests",  # TODO(GYP): visibility?
   ]
 
   if (!is_ios) {
     deps += [
       "//v8:postmortem-metadata",
@@ skipping 242 matching lines @@
   assert(target_name != "")  # Mark as used.
   sources = invoker.actual_sources
   assert(
       sources == invoker.actual_sources,
       "Do not use a platform name in your output directory (found \"$root_build_dir\"). http://crbug.com/548283")
 }
 
 assert_valid_out_dir("_unused") {
   actual_sources = [ "$root_build_dir/foo" ]
 }