Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: net/quic/chromium/quic_test_packet_maker.h

Issue 2838113002: Simplify QUIC tests by adding a MakeInitialSettingsPacket method (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | net/quic/chromium/quic_test_packet_maker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_test_packet_maker.h
diff --git a/net/quic/chromium/quic_test_packet_maker.h b/net/quic/chromium/quic_test_packet_maker.h
index 6bfb4cc9952d1006d712cab71c7a34d11db268e5..eb3f53c018d0e0c88e61fc59eb727c21b8bf52ed 100644
--- a/net/quic/chromium/quic_test_packet_maker.h
+++ b/net/quic/chromium/quic_test_packet_maker.h
@@ -216,20 +216,16 @@ class QuicTestPacketMaker {
SpdyHeaderBlock headers,
QuicStreamOffset* offset);
- std::unique_ptr<QuicReceivedPacket> MakeSettingsPacket(
+ // Creates a packet containing the initial SETTINGS frame, and saves the
+ // headers stream offset into |offset|.
+ std::unique_ptr<QuicReceivedPacket> MakeInitialSettingsPacket(
QuicPacketNumber packet_number,
- SpdySettingsIds id,
- size_t value,
- bool should_include_version,
QuicStreamOffset* offset);
// Same as above, but also saves the serialized QUIC stream data in
// |stream_data|.
- std::unique_ptr<QuicReceivedPacket> MakeSettingsPacketAndSaveData(
+ std::unique_ptr<QuicReceivedPacket> MakeInitialSettingsPacketAndSaveData(
QuicPacketNumber packet_number,
- SpdySettingsIds id,
- size_t value,
- bool should_include_version,
QuicStreamOffset* offset,
std::string* stream_data);
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | net/quic/chromium/quic_test_packet_maker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698