Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2837993002:
[Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters. (Closed)
Description[Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters.
This in preparation for USER_EVENTS, which is a commit only type and
some fields like version and not useful. We want to save as much
bandwidth as possible, and switching to optional saves us ~2 bytes each
before compression.
BUG=714828
Review-Url: https://codereview.chromium.org/2837993002
Cr-Commit-Position: refs/heads/master@{#468104}
Committed: https://chromium.googlesource.com/chromium/src/+/f9bf5ca85577c34702afe733dcb6d1d98ed728a0
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== [Sync] Remove required fields from SyncData and obsolete ThrottleParameters. BUG=714828 ========== to ========== [Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters. BUG=714828 ==========
skym@chromium.org changed reviewers: + bartekg@chromium.org, pavely@chromium.org
The CQ bit was checked by skym@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters. BUG=714828 ========== to ========== [Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters. This in preparation for USER_EVENTS, which is a commit only type and some fields like version and not useful. We want to save as much bandwidth as possible, and switching to optional saves us ~2 bytes each before compression. BUG=714828 ==========
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
LGTM
The CQ bit was checked by skym@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by skym@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493406538234230, "parent_rev":
"77b3d04f17b4cc52bef217f7876df2531f12b2e7", "commit_rev":
"f9bf5ca85577c34702afe733dcb6d1d98ed728a0"}
Message was sent while issue was closed.
Description was changed from ========== [Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters. This in preparation for USER_EVENTS, which is a commit only type and some fields like version and not useful. We want to save as much bandwidth as possible, and switching to optional saves us ~2 bytes each before compression. BUG=714828 ========== to ========== [Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters. This in preparation for USER_EVENTS, which is a commit only type and some fields like version and not useful. We want to save as much bandwidth as possible, and switching to optional saves us ~2 bytes each before compression. BUG=714828 Review-Url: https://codereview.chromium.org/2837993002 Cr-Commit-Position: refs/heads/master@{#468104} Committed: https://chromium.googlesource.com/chromium/src/+/f9bf5ca85577c34702afe733dcb6... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f9bf5ca85577c34702afe733dcb6... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
