Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: components/sync/protocol/sync.proto

Issue 2837993002: [Sync] Remove required fields from SyncEntity and obsolete ThrottleParameters. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/protocol/sync.proto
diff --git a/components/sync/protocol/sync.proto b/components/sync/protocol/sync.proto
index 611c16bf6a8e6643a4f7dc4f190269031f14b50a..49a2d70de5587892d512b8cef71d5921fcc08c76 100644
--- a/components/sync/protocol/sync.proto
+++ b/components/sync/protocol/sync.proto
@@ -179,7 +179,9 @@ message SyncEntity {
// always positive and indentifies the revision of the item data being sent
// to the client.
// Present in both GetUpdatesResponse and CommitMessage.
- required int64 version = 4;
+ // WARNING: This field used to be required before M60. Any client before this
+ // will fail to deserialize if this field is missing.
+ optional int64 version = 4;
// Last modification time (in java time milliseconds)
// Present in both GetUpdatesResponse and CommitMessage.
@@ -197,7 +199,9 @@ message SyncEntity {
// depended on the uniqueness of the property since November 2009; it was
// removed from Chromium by http://codereview.chromium.org/371029 .
// Present in both GetUpdatesResponse and CommitMessage.
- required string name = 7;
+ // WARNING: This field used to be required before M60. Any client before this
+ // will fail to deserialize if this field is missing.
+ optional string name = 7;
// The name of this item. Same as |name|.
// |non_unique_name| should take precedence over the |name| value if both
@@ -965,15 +969,6 @@ message AuthenticateResponse {
optional UserIdentification user = 1;
};
-message ThrottleParameters {
- // Deprecated. Remove this from the server side.
- required int32 min_measure_payload_size = 1;
- required double target_utilization = 2;
- required double measure_interval_max = 3;
- required double measure_interval_min = 4;
- required double observation_window = 5;
-};
-
message ClientToServerResponse {
optional CommitResponse commit = 1;
optional GetUpdatesResponse get_updates = 2;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698