Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2837943004: dbus: Stop collecting DBus.RejectedSignalCount histogram (Closed)

Created:
3 years, 8 months ago by hashimoto
Modified:
3 years, 8 months ago
Reviewers:
Adam Rice, satorux1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

dbus: Stop collecting DBus.RejectedSignalCount histogram Also, use shorter timeout for SignalSenderVerificationTest.TestSignalRejected which was disabled because of its slowness. BUG=407063, 643537 TEST=dbus_unittests Review-Url: https://codereview.chromium.org/2837943004 Cr-Commit-Position: refs/heads/master@{#466912} Committed: https://chromium.googlesource.com/chromium/src/+/72254d5183b29735f1cfe999cc7926f55c4dedb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M dbus/object_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M dbus/signal_sender_verification_unittest.cc View 1 chunk +2 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
hashimoto
3 years, 8 months ago (2017-04-25 06:08:24 UTC) #3
satorux1
lgtm
3 years, 8 months ago (2017-04-25 06:19:23 UTC) #5
Adam Rice
non-owner LGTM.
3 years, 8 months ago (2017-04-25 06:38:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837943004/1
3 years, 8 months ago (2017-04-25 07:09:57 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 07:13:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72254d5183b29735f1cfe999cc79...

Powered by Google App Engine
This is Rietveld 408576698