Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: dbus/signal_sender_verification_unittest.cc

Issue 2837943004: dbus: Stop collecting DBus.RejectedSignalCount histogram (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/object_proxy.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/signal_sender_verification_unittest.cc
diff --git a/dbus/signal_sender_verification_unittest.cc b/dbus/signal_sender_verification_unittest.cc
index 7f5c790683dc27fa3f9507993ae978b4cfbb8f38..3a5f299ab8ed47c9bdcc983605c5a3adf2fc8dee 100644
--- a/dbus/signal_sender_verification_unittest.cc
+++ b/dbus/signal_sender_verification_unittest.cc
@@ -197,27 +197,15 @@ TEST_F(SignalSenderVerificationTest, TestSignalAccepted) {
ASSERT_EQ(kMessage, test_signal_string_);
}
-// Disabled, http://crbug.com/407063 .
-TEST_F(SignalSenderVerificationTest, DISABLED_TestSignalRejected) {
- // To make sure the histogram instance is created.
- UMA_HISTOGRAM_COUNTS("DBus.RejectedSignalCount", 0);
- base::HistogramBase* reject_signal_histogram =
- base::StatisticsRecorder::FindHistogram("DBus.RejectedSignalCount");
- std::unique_ptr<base::HistogramSamples> samples1(
- reject_signal_histogram->SnapshotSamples());
-
+TEST_F(SignalSenderVerificationTest, TestSignalRejected) {
const char kNewMessage[] = "hello, new world";
test_service2_->SendTestSignal(kNewMessage);
// This test tests that our callback is NOT called by the ObjectProxy.
// Sleep to have message delivered to the client via the D-Bus service.
- base::PlatformThread::Sleep(TestTimeouts::action_timeout());
-
- std::unique_ptr<base::HistogramSamples> samples2(
- reject_signal_histogram->SnapshotSamples());
+ base::PlatformThread::Sleep(TestTimeouts::tiny_timeout());
ASSERT_EQ("", test_signal_string_);
- EXPECT_EQ(samples1->TotalCount() + 1, samples2->TotalCount());
}
TEST_F(SignalSenderVerificationTest, TestOwnerChanged) {
« no previous file with comments | « dbus/object_proxy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698