Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/bindings/scripts/utilities.py

Issue 2837923003: Make NodeFilter a legacy callback interface. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/utilities.py
diff --git a/third_party/WebKit/Source/bindings/scripts/utilities.py b/third_party/WebKit/Source/bindings/scripts/utilities.py
index 98d42660595d63a766a5fb217003b9fc139be894..53c9b1a908326817ca59a320f6b8f89f14b96493 100644
--- a/third_party/WebKit/Source/bindings/scripts/utilities.py
+++ b/third_party/WebKit/Source/bindings/scripts/utilities.py
@@ -344,9 +344,9 @@ def write_pickle_file(pickle_filename, data):
# Leading and trailing context (e.g. following '{') used to avoid false matches.
################################################################################
-def is_callback_interface_from_idl(file_contents):
+def is_non_legacy_callback_interface_from_idl(file_contents):
match = re.search(r'callback\s+interface\s+\w+\s*{', file_contents)
bashi 2017/04/27 08:49:49 Could you add a comment why we search 'const' to d
Yuki 2017/04/27 12:18:29 |file_contents| doesn't include any comment, right
tkent 2017/04/28 06:13:36 Done. Added a comment.
- return bool(match)
+ return bool(match) and not re.search(r'\bconst\b', file_contents)
def should_generate_impl_file_from_idl(file_contents):

Powered by Google App Engine
This is Rietveld 408576698