Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

Issue 2837923003: Make NodeFilter a legacy callback interface. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
index e3f71df605cf0efa40523e759106905434045618..da631315c5dbb5e3b1416ce25425923424118abb 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
@@ -127,6 +127,12 @@ v8::Local<v8::Function> V8PerContextData::ConstructorForTypeSlowCase(
return v8::Local<v8::Function>();
}
+ if (type->wrapper_type_prototype ==
+ WrapperTypeInfo::kWrapperTypeNoPrototype) {
+ constructor_map_.Set(type, interface_object);
+ return interface_object;
Yuki 2017/04/27 12:18:28 nit: Ideally, we shouldn't skip InstallConditional
tkent 2017/04/28 06:13:36 Done.
+ }
+
v8::Local<v8::Value> prototype_value;
if (!interface_object
->Get(current_context, V8AtomicString(isolate_, "prototype"))

Powered by Google App Engine
This is Rietveld 408576698