Make NodeFilter a legacy callback interface.

third_party/WebKit/Source/bindings/scripts/utilities.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility functions (file reading, simple IDL parsing by regexes) for IDL build.
 
 Design doc: http://www.chromium.org/developers/design-documents/idl-build
 """
 
 import os
@@ skipping 326 matching lines @@
 
 ################################################################################
 # IDL parsing
 #
 # TODO(bashi): We use regular expressions for parsing; this is incorrect
 # (Web IDL is not a regular language) and broken. Remove these functions and
 # always use the parser and ASTs.
 # Leading and trailing context (e.g. following '{') used to avoid false matches.
 ################################################################################
 
-def is_callback_interface_from_idl(file_contents):
+def is_non_legacy_callback_interface_from_idl(file_contents):
     match = re.search(r'callback\s+interface\s+\w+\s*{', file_contents)

[bashi, 2017/04/27 08:49:49]

Could you add a comment why we search 'const' to detect legacy callback
interface?

[Yuki, 2017/04/27 12:18:29]

|file_contents| doesn't include any comment, right?

[tkent, 2017/04/28 06:13:36]

Done. Added a comment.

-    return bool(match)
+    return bool(match) and not re.search(r'\bconst\b', file_contents)
 
 
 def should_generate_impl_file_from_idl(file_contents):
     """True when a given IDL file contents could generate .h/.cpp files."""
     # FIXME: This would be error-prone and we should use AST rather than
     # improving the regexp pattern.
     match = re.search(r'(interface|dictionary|exception)\s+\w+', file_contents)
     return bool(match)
 
 
@@ skipping 159 matching lines @@
 
         # Remember an open brace.
         match = re_last_brace.search(line)
         was_open_brace = (match and match.group('last') == '{' and 'namespace' not in line)
 
     # Let |'\n'.join| emit the last newline.
     if output:
         output.append('')
 
     return '\n'.join(output)