remoting/protocol/authenticator_test_base.cc - Issue 2837863004: Use base::OneShotTimer instead of base::Timer(false, false)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/authenticator_test_base.cc

Issue 2837863004: Use base::OneShotTimer instead of base::Timer(false, false)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/authenticator_test_base.cc

diff --git a/remoting/protocol/authenticator_test_base.cc b/remoting/protocol/authenticator_test_base.cc

index 7b26f0a90c37fc2a5621eadccd7ddad9b7111b7d..7f9e61b1fdac6e8baedfaa3db4b7d25881bb2b78 100644

--- a/remoting/protocol/authenticator_test_base.cc

+++ b/remoting/protocol/authenticator_test_base.cc

@@ -145,7 +145,7 @@ void AuthenticatorTestBase::RunChannelAuth(bool expected_fail) {

// Ensure that .Run() does not run unbounded if the callbacks are never

// called.

- base::Timer shutdown_timer(false, false);

+ base::OneShotTimer shutdown_timer;

shutdown_timer.Start(FROM_HERE, TestTimeouts::action_timeout(),

base::MessageLoop::QuitWhenIdleClosure());

base::RunLoop().Run();