extensions/browser/api/cast_channel/cast_channel_api.cc - Issue 2837863004: Use base::OneShotTimer instead of base::Timer(false, false)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_channel_api.cc

Issue 2837863004: Use base::OneShotTimer instead of base::Timer(false, false)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/cast_channel_api.cc

diff --git a/extensions/browser/api/cast_channel/cast_channel_api.cc b/extensions/browser/api/cast_channel/cast_channel_api.cc

index 7f64f24d24dd63d99ea3624fde9096a4438823e3..cb7ddad6d733422122817a1b4c4de4c8178b833c 100644

--- a/extensions/browser/api/cast_channel/cast_channel_api.cc

+++ b/extensions/browser/api/cast_channel/cast_channel_api.cc

@@ -334,7 +334,7 @@ void CastChannelOpenFunction::AsyncWorkStart() {

std::unique_ptr<base::Timer> injected_timer =

api_->GetInjectedTimeoutTimerForTest();

if (injected_timer) {

- keep_alive->SetTimersForTest(base::MakeUnique<base::Timer>(false, false),

+ keep_alive->SetTimersForTest(base::MakeUnique<base::OneShotTimer>(),

std::move(injected_timer));

}

delegate.reset(keep_alive);