Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2837583002: [Benchmarks] Remove V8.TodoMVC benchmark (Closed)

Created:
3 years, 8 months ago by Michael Hablich
Modified:
3 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Benchmarks] Remove V8.TodoMVC benchmark This benchmark is no longer of use because we are running RCS-based benchmarks nowadays. R=nednguyen@google.com,mvstanton@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2837583002 Cr-Commit-Position: refs/heads/master@{#466327} Committed: https://chromium.googlesource.com/chromium/src/+/d7a6b51c01f1ad0c3de33a6eb8aa92c0232db1e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3068 lines, -6589 lines) Patch
M testing/buildbot/chromium.perf.json View 1443 chunks +2700 lines, -5532 lines 0 comments Download
M testing/buildbot/chromium.perf.fyi.json View 307 chunks +368 lines, -899 lines 0 comments Download
M tools/perf/benchmark.csv View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/v8.py View 1 chunk +0 lines, -55 lines 0 comments Download
D tools/perf/page_sets/data/todomvc.json View 1 chunk +0 lines, -33 lines 0 comments Download
D tools/perf/page_sets/data/todomvc_000.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/todomvc.py View 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Hablich
PTAL
3 years, 8 months ago (2017-04-21 13:10:12 UTC) #1
nednguyen
lgtm
3 years, 8 months ago (2017-04-21 13:12:52 UTC) #2
mvstanton
lgtm
3 years, 8 months ago (2017-04-21 13:13:19 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-21 13:40:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837583002/1
3 years, 8 months ago (2017-04-21 14:23:15 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 14:27:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7a6b51c01f1ad0c3de33a6eb8aa...

Powered by Google App Engine
This is Rietveld 408576698