Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2837583002: [Benchmarks] Remove V8.TodoMVC benchmark (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/page_sets/data/todomvc.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index f835c1097d59f4627ca786cfd27567e59d1cbe90..6e1d0b35e818a870e30f22804ab71f4d30360f6a 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -127,61 +127,6 @@ class _InfiniteScrollBenchmark(perf_benchmark.PerfBenchmark):
return True
-@benchmark.Owner(emails=['jochen@chromium.org'])
-class V8TodoMVC(perf_benchmark.PerfBenchmark):
- """Measures V8 Execution metrics on the TodoMVC examples."""
- page_set = page_sets.TodoMVCPageSet
-
- def CreateTimelineBasedMeasurementOptions(self):
- return CreateV8TimelineBasedMeasurementOptions()
-
- @classmethod
- def Name(cls):
- return 'v8.todomvc'
-
- @classmethod
- def ShouldDisable(cls, possible_browser):
- # This benchmark is flaky on Samsung Galaxy S5s.
- # http://crbug.com/644826
- return possible_browser.platform.GetDeviceTypeName() == 'SM-G900H'
-
- @classmethod
- def ShouldTearDownStateAfterEachStoryRun(cls):
- return True
-
-@benchmark.Disabled('all')
-@benchmark.Owner(emails=['mvstaton@chromium.org'])
-class V8TodoMVCTurbo(V8TodoMVC):
- """Measures V8 Execution metrics on the TodoMVC examples
- using Ignition+TurboFan."""
-
- page_set = page_sets.TodoMVCPageSet
-
- def SetExtraBrowserOptions(self, options):
- super(V8TodoMVCTurbo, self).SetExtraBrowserOptions(options)
- v8_helper.EnableTurbo(options)
-
- @classmethod
- def Name(cls):
- return 'v8.todomvc-turbo'
-
-
-@benchmark.Owner(emails=['hablich@chromium.org'])
-class V8TodoMVCClassic(V8TodoMVC):
- """Measures V8 Execution metrics on the TodoMVC examples
- using the Classic pipeline."""
-
- page_set = page_sets.TodoMVCPageSet
-
- def SetExtraBrowserOptions(self, options):
- super(V8TodoMVCClassic, self).SetExtraBrowserOptions(options)
- v8_helper.EnableClassic(options)
-
- @classmethod
- def Name(cls):
- return 'v8.todomvc-classic'
-
-
@benchmark.Owner(emails=['ulan@chromium.org'])
class V8InfiniteScroll(_InfiniteScrollBenchmark):
"""Measures V8 GC metrics and memory usage while scrolling the top web pages.
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/page_sets/data/todomvc.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698