Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2837483002: [Merge to M59] Feedback: User email section should only be visible when useful (Closed)

Created:
3 years, 8 months ago by afakhry
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, apacible+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to M59] Feedback: User email section should only be visible when useful When user is not logged on, default is to report anonymously. No user email is available for us. In this case, there's no need to show the user email section. So we'll keep it hidden until a valid email entry is added. TBR=xiyuan@chromium.org BUG=711357 TEST=login in guest mode, open feedback app (Alt+Shift+i), notice that there's no user-email section at all. For logged in users, at least there are two entries; a user-email, and "Report anonymously". CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2826563002 Cr-Commit-Position: refs/heads/master@{#465057} (cherry picked from commit 8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d) Review-Url: https://codereview.chromium.org/2837483002 . Cr-Commit-Position: refs/branch-heads/3071@{#107} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/feedback/html/default.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/js/feedback.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
afakhry
3 years, 8 months ago (2017-04-21 00:42:49 UTC) #1 
Description was changed from

==========
[Merge to M59] Feedback: User email section should only be visible when useful

When user is not logged on, default is to report anonymously. No
user email is available for us. In this case, there's no need to
show the user email section. So we'll keep it hidden until a valid
email entry is added.

TBR=xiyuan@chromium.org
BUG=711357
TEST=login in guest mode, open feedback app (Alt+Shift+i), notice that
     there's no user-email section at all. For logged in users, at least
     there are two entries; a user-email, and "Report anonymously".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826563002
Cr-Commit-Position: refs/heads/master@{#465057}
(cherry picked from commit 8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d)
==========

to

==========
[Merge to M59] Feedback: User email section should only be visible when useful

When user is not logged on, default is to report anonymously. No
user email is available for us. In this case, there's no need to
show the user email section. So we'll keep it hidden until a valid
email entry is added.

TBR=xiyuan@chromium.org
BUG=711357
TEST=login in guest mode, open feedback app (Alt+Shift+i), notice that
     there's no user-email section at all. For logged in users, at least
     there are two entries; a user-email, and "Report anonymously".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826563002
Cr-Commit-Position: refs/heads/master@{#465057}
(cherry picked from commit 8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d)

Review-Url: https://codereview.chromium.org/2837483002 .
Cr-Commit-Position: refs/branch-heads/3071@{#107}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
==========

Powered by Google App Engine
This is Rietveld 408576698