Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2826563002: Feedback: User email section should only be visible when useful (Closed)

Created:
3 years, 8 months ago by afakhry
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, apacible+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Feedback: User email section should only be visible when useful When user is not logged on, default is to report anonymously. No user email is available for us. In this case, there's no need to show the user email section. So we'll keep it hidden until a valid email entry is added. BUG=711357 TEST=login in guest mode, open feedback app (Alt+Shift+i), notice that there's no user-email section at all. For logged in users, at least there are two entries; a user-email, and "Report anonymously". CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2826563002 Cr-Commit-Position: refs/heads/master@{#465057} Committed: https://chromium.googlesource.com/chromium/src/+/8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/feedback/html/default.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/js/feedback.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
afakhry
Xiyuan, please take a look. Thanks!
3 years, 8 months ago (2017-04-17 21:58:54 UTC) #5
xiyuan
lgtm
3 years, 8 months ago (2017-04-17 22:18:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826563002/1
3 years, 8 months ago (2017-04-17 22:30:15 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 23:20:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a299993ec8d4a6a5c58dfa30dac...

Powered by Google App Engine
This is Rietveld 408576698