Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: third_party/WebKit/Source/core/dom/ClassicPendingScript.h

Issue 2837413002: 1. Check that ClassicPendingScript is not accessed after prefinalizer explicitly (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ClassicPendingScript.h
diff --git a/third_party/WebKit/Source/core/dom/ClassicPendingScript.h b/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
index 00b2e4415e22449b2b6948e21fc4e6f70d2809a1..0405f5b99bafc6797e818c2cb045d1a8da683cac 100644
--- a/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
+++ b/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
@@ -86,6 +86,12 @@ class CORE_EXPORT ClassicPendingScript final
bool integrity_failure_;
Member<ScriptStreamer> streamer_;
+
+ // This is a temporary flag to confirm that ClassicPendingScript is not
+ // touched after its refinalizer call and thus https://crbug.com/715309
+ // doesn't break assumptions.
+ // TODO(hiroshige): Check the state in more general way.
+ bool prefinalizer_called_ = false;
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698