Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2837413002: 1. Check that ClassicPendingScript is not accessed after prefinalizer explicitly (Closed)

Created:
2 years, 2 months ago by hiroshige
Modified:
2 years, 1 month ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that ClassicPendingScript is not accessed after prefinalizer explicitly To ensure upcoming changes to prefinalizers around PendingScript, this CL asserts that ClassicPendingScript is not touched after prefinalization. The state transition of ClassicPendingScript and ScriptStreamer is complicated, and I'd like to check that our change doesn't break the their assumptions. BUG=715309 Review-Url: https://codereview.chromium.org/2837413002 Cr-Commit-Position: refs/heads/master@{#467205} Committed: https://chromium.googlesource.com/chromium/src/+/f72cff34bada6f453c14170273e2c67354209109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (9 generated)
kouhei (in TOK)
lgtm
2 years, 2 months ago (2017-04-26 00:21:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837413002/1
2 years, 1 month ago (2017-04-26 02:08:10 UTC) #9
commit-bot: I haz the power
2 years, 1 month ago (2017-04-26 02:12:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f72cff34bada6f453c14170273e2...

Powered by Google App Engine
This is Rietveld 408576698