Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: third_party/WebKit/Source/core/dom/ClassicPendingScript.h

Issue 2837413002: 1. Check that ClassicPendingScript is not accessed after prefinalizer explicitly (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ClassicPendingScript_h 5 #ifndef ClassicPendingScript_h
6 #define ClassicPendingScript_h 6 #define ClassicPendingScript_h
7 7
8 #include "bindings/core/v8/ScriptStreamer.h" 8 #include "bindings/core/v8/ScriptStreamer.h"
9 #include "core/dom/ClassicScript.h" 9 #include "core/dom/ClassicScript.h"
10 #include "core/dom/PendingScript.h" 10 #include "core/dom/PendingScript.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 void NotifyFinished(Resource*) override; 79 void NotifyFinished(Resource*) override;
80 String DebugName() const override { return "PendingScript"; } 80 String DebugName() const override { return "PendingScript"; }
81 void NotifyAppendData(ScriptResource*) override; 81 void NotifyAppendData(ScriptResource*) override;
82 82
83 // MemoryCoordinatorClient 83 // MemoryCoordinatorClient
84 void OnPurgeMemory() override; 84 void OnPurgeMemory() override;
85 85
86 bool integrity_failure_; 86 bool integrity_failure_;
87 87
88 Member<ScriptStreamer> streamer_; 88 Member<ScriptStreamer> streamer_;
89
90 // This is a temporary flag to confirm that ClassicPendingScript is not
91 // touched after its refinalizer call and thus https://crbug.com/715309
92 // doesn't break assumptions.
93 // TODO(hiroshige): Check the state in more general way.
94 bool prefinalizer_called_ = false;
89 }; 95 };
90 96
91 } // namespace blink 97 } // namespace blink
92 98
93 #endif // PendingScript_h 99 #endif // PendingScript_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698