chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java - Issue 2837283003: [Android] Log notification shown/blocked for all other notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

Issue 2837283003: [Android] Log notification shown/blocked for all other notifications (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

index 5bc1221c9ca81374c76449e1818badff75a434e6..6035b0cb9f4d412501470a780ef9e09d81de4b75 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

@@ -582,6 +582,8 @@ public class NotificationPlatformBridge {

String platformTag = makePlatformTag(notificationId, origin, tag);

if (webApkPackage.isEmpty()) {

mNotificationManager.notify(platformTag, PLATFORM_ID, notificationBuilder.build());

+ NotificationUmaTracker.getInstance().onNotificationShown(

+ NotificationUmaTracker.SITES, ChannelDefinitions.CHANNEL_ID_SITES);

} else {

WebApkNotificationClient.notifyNotification(

webApkPackage, notificationBuilder, platformTag, PLATFORM_ID);