Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5503)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Issue 2837283003: [Android] Log notification shown/blocked for all other notifications (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
index 198ca1c171c391013dd0a92ebe35ddf64ea7b76a..8c866a91a3a6601e7a1bd6ebde914fb3d5a90bdb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
@@ -42,6 +42,7 @@ import org.chromium.chrome.browser.notifications.ChannelDefinitions;
import org.chromium.chrome.browser.notifications.ChromeNotificationBuilder;
import org.chromium.chrome.browser.notifications.NotificationBuilderFactory;
import org.chromium.chrome.browser.notifications.NotificationConstants;
+import org.chromium.chrome.browser.notifications.NotificationUmaTracker;
import org.chromium.content_public.common.MediaMetadata;
import java.util.ArrayList;
@@ -108,6 +109,8 @@ public class MediaNotificationManager {
NotificationConstants.GROUP_MEDIA_REMOTE));
}
+ private final NotificationUmaTracker mNotificationUmaTracker;
+
private int mNotificationId;
// ListenerService running for the notification. Only non-null when showing.
@@ -464,7 +467,8 @@ public class MediaNotificationManager {
public static void show(MediaNotificationInfo notificationInfo) {
MediaNotificationManager manager = sManagers.get(notificationInfo.id);
if (manager == null) {
- manager = new MediaNotificationManager(notificationInfo.id);
+ manager = new MediaNotificationManager(
+ NotificationUmaTracker.getInstance(), notificationInfo.id);
sManagers.put(notificationInfo.id, manager);
}
@@ -634,7 +638,8 @@ public class MediaNotificationManager {
}
@VisibleForTesting
- MediaNotificationManager(int notificationId) {
+ MediaNotificationManager(NotificationUmaTracker umaTracker, int notificationId) {
+ mNotificationUmaTracker = umaTracker;
mNotificationId = notificationId;
mActionToButtonInfo = new SparseArray<>();
@@ -675,6 +680,8 @@ public class MediaNotificationManager {
mService = service;
updateNotification();
+ mNotificationUmaTracker.onNotificationShown(
+ NotificationUmaTracker.MEDIA, ChannelDefinitions.CHANNEL_ID_MEDIA);
}
/**

Powered by Google App Engine
This is Rietveld 408576698