Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

Issue 2837283003: [Android] Log notification shown/blocked for all other notifications (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
index c8fc3942d52c20f825f0455474580fcee36e3423..312d43d4a11fc9a0c5debed7cb6bade4b1677316 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
@@ -27,10 +27,9 @@ import java.lang.reflect.Method;
*/
public class NotificationUmaTracker {
private static final String TAG = "NotifsUMATracker";
-
@Retention(RetentionPolicy.SOURCE)
- @IntDef({DOWNLOAD_FILES, DOWNLOAD_PAGES, CLOSE_INCOGNITO, CONTENT_SUGGESTION,
- SYSTEM_NOTIFICATION_TYPE_BOUNDARY})
+ @IntDef({DOWNLOAD_FILES, DOWNLOAD_PAGES, CLOSE_INCOGNITO, CONTENT_SUGGESTION, MEDIA_CAPTURE,
+ PHYSICAL_WEB, MEDIA, SITES, SYNC, SYSTEM_NOTIFICATION_TYPE_BOUNDARY})
public @interface SystemNotificationType {}
/*
@@ -41,11 +40,19 @@ public class NotificationUmaTracker {
* A SystemNotificationType value can also be saved in shared preferences.
*/
public static final int DOWNLOAD_FILES = 0;
+
public static final int DOWNLOAD_PAGES = 1;
+
public static final int CLOSE_INCOGNITO = 2;
+
public static final int CONTENT_SUGGESTION = 3;
+ public static final int MEDIA_CAPTURE = 4;
+ public static final int PHYSICAL_WEB = 5;
+ public static final int MEDIA = 6;
+ public static final int SITES = 7;
+ public static final int SYNC = 8;
- private static final int SYSTEM_NOTIFICATION_TYPE_BOUNDARY = 4;
+ private static final int SYSTEM_NOTIFICATION_TYPE_BOUNDARY = 9;
private static final String LAST_SHOWN_NOTIFICATION_TYPE_KEY =
"NotificationUmaTracker.LastShownNotificationType";

Powered by Google App Engine
This is Rietveld 408576698