Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2837053004: Allows MHTM page to open a popup (Closed)

Created:
3 years, 8 months ago by jianli
Modified:
3 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allows MHTM page to open a popup BUG=704722 TEST=test updated Review-Url: https://codereview.chromium.org/2837053004 Cr-Commit-Position: refs/heads/master@{#467446} Committed: https://chromium.googlesource.com/chromium/src/+/3024459c9f7cd7783b63535623244a21e9d4d4e6

Patch Set 1 #

Patch Set 2 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/MHTMLTest.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
jianli
3 years, 8 months ago (2017-04-24 21:12:54 UTC) #3
Mike West
Code change looks correct, but please add tests for this behavior.
3 years, 8 months ago (2017-04-25 07:38:01 UTC) #7
jianli
Updated test.
3 years, 8 months ago (2017-04-25 23:30:19 UTC) #9
Mike West
lgtm
3 years, 8 months ago (2017-04-26 09:30:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837053004/20001
3 years, 8 months ago (2017-04-26 20:42:19 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 20:48:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3024459c9f7cd7783b6353562324...

Powered by Google App Engine
This is Rietveld 408576698