Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: third_party/WebKit/Source/web/tests/MHTMLTest.cpp

Issue 2837053004: Allows MHTM page to open a popup (Closed)
Patch Set: Update test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/MHTMLTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/MHTMLTest.cpp b/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
index 494f0713505ffc3e915dcbb684d4756014b7332f..d4f346db172931ffcc5eb88fd14174c434e17bbf 100644
--- a/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
+++ b/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
@@ -276,8 +276,11 @@ TEST_F(MHTMLTest, EnforceSandboxFlags) {
Document* document = frame->GetDocument();
ASSERT_TRUE(document);
- // Full sandboxing should be turned on.
- EXPECT_TRUE(document->IsSandboxed(kSandboxAll));
+ // Full sandboxing with the exception to new top-level windows should be
+ // turned on.
+ EXPECT_EQ(kSandboxAll & ~(kSandboxPopups |
+ kSandboxPropagatesToAuxiliaryBrowsingContexts),
+ document->GetSandboxFlags());
// MHTML document should be loaded into unique origin.
EXPECT_TRUE(document->GetSecurityOrigin()->IsUnique());
« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698