Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2836973002: Enable find-in-page across GuestViews. (Closed)

Created:
3 years, 8 months ago by paulmeyer
Modified:
3 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable find-in-page across GuestViews. This patch enables find-in-page to work across GuestViews, including WebViews and PDFs, as explained in this design doc: https://drive.google.com/open?id=1tl1L99oTgqQxolV7jRvDLzFQ9K251rQ_E16mOwB-BuU. Specifically, this will allow find-in-page to work with embedded PDFs, which has been a (very) longstanding bug in Chrome. This patch also cleans up code that was previously used to route find requests to the guest WebContents in the case of full-page GuestViews. This shortcut is no longer needed, as this patch implements a more general solution to traversing frames across all WebContentses during a find session. Note that this is an attempt to reland a fixed version of the reverted CL here: https://codereview.chromium.org/2700613003/ BUG=55421 Review-Url: https://codereview.chromium.org/2836973002 Cr-Commit-Position: refs/heads/master@{#467124} Committed: https://chromium.googlesource.com/chromium/src/+/feafc2de2c3e515247b5f45ab9ac9a4139b6cd46

Patch Set 1 : Original CL. #

Patch Set 2 : Fixes after revert. #

Total comments: 4

Patch Set 3 : Addressed comments by thestig@. #

Patch Set 4 : Small fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -337 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chrome_find_request_manager_browsertest.cc View 3 chunks +30 lines, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 4 chunks +61 lines, -22 lines 0 comments Download
M components/guest_view/browser/guest_view_base.h View 3 chunks +0 lines, -15 lines 0 comments Download
M components/guest_view/browser/guest_view_base.cc View 3 chunks +0 lines, -41 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.h View 2 chunks +0 lines, -13 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 3 chunks +0 lines, -46 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 4 chunks +10 lines, -12 lines 0 comments Download
M content/browser/find_request_manager.h View 5 chunks +15 lines, -11 lines 0 comments Download
M content/browser/find_request_manager.cc View 14 chunks +203 lines, -61 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 7 chunks +43 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 14 chunks +127 lines, -32 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.cc View 1 chunk +0 lines, -12 lines 0 comments Download
A content/test/data/find_in_embedded_pdf_page.html View 1 chunk +13 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 2 3 chunks +19 lines, -29 lines 0 comments Download

Messages

Total messages: 30 (23 generated)
paulmeyer
thestig@chromium.org: Please review new changes in pdf/pdfium/pdfium_engine.cc nick@chromium.org: Please review new changes in content/browser/browser_plugin/browser_plugin_guest.cc and ...
3 years, 8 months ago (2017-04-24 18:00:55 UTC) #6
ncarter (slow)
lgtm
3 years, 8 months ago (2017-04-24 20:49:52 UTC) #7
Lei Zhang
I have to admit either I didn't write the PDF find code, or I it's ...
3 years, 8 months ago (2017-04-24 21:11:13 UTC) #8
paulmeyer
thestig@: PTAL. https://codereview.chromium.org/2836973002/diff/80001/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/2836973002/diff/80001/pdf/pdfium/pdfium_engine.cc#newcode2209 pdf/pdfium/pdfium_engine.cc:2209: if (current_index >= last_index) { On 2017/04/24 ...
3 years, 8 months ago (2017-04-24 21:44:22 UTC) #10
Lei Zhang
lgtm
3 years, 8 months ago (2017-04-24 21:54:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836973002/140001
3 years, 8 months ago (2017-04-25 21:39:50 UTC) #26
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 21:46:55 UTC) #29
Message was sent while issue was closed.
Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/feafc2de2c3e515247b5f45ab9ac...

Powered by Google App Engine
This is Rietveld 408576698