extensions/browser/guest_view/extension_options/extension_options_guest.h - Issue 2836973002: Enable find-in-page across GuestViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 2836973002: Enable find-in-page across GuestViews. (Closed)

Patch Set: Small fix. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/data/find_in_embedded_pdf_page.html ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.h

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.h b/extensions/browser/guest_view/extension_options/extension_options_guest.h

index 2bb279050c818526fdfb5248d86685ac79fabebf..6b2933a7493e36d9392728527f70c8a8507f1f05 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.h

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.h

@@ -35,7 +35,6 @@ class ExtensionOptionsGuest

int GetTaskPrefix() const final;

bool IsPreferredSizeModeEnabled() const final;

void OnPreferredSizeChanged(const gfx::Size& pref_size) final;

- bool ShouldHandleFindRequestsForEmbedder() const final;

// content::WebContentsDelegate implementation.

content::WebContents* OpenURLFromTab(