Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2836913004: [turbofan] General consolidation of element access. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] General consolidation of element access. Avoid TransitionElementsKind when storing to objects which only differ in holeyness of their elements kind. Instead go for polymorphic CheckMaps, which can often by optimized and avoid the mutation of the array map. This generalizes the approach https://codereview.chromium.org/2836943003 which covered only element loads. R=yangguo@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2836913004 Cr-Commit-Position: refs/heads/master@{#44828} Committed: https://chromium.googlesource.com/v8/v8/+/ed573cee5c1d1e42158829dc0b92fb697234e121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -41 lines) Patch
M src/compiler/access-info.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/access-info.cc View 3 chunks +35 lines, -39 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-25 04:25:50 UTC) #1
Yang
On 2017/04/25 04:25:50, Benedikt Meurer wrote: lgtm.
3 years, 8 months ago (2017-04-25 04:54:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836913004/1
3 years, 8 months ago (2017-04-25 04:56:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/ed573cee5c1d1e42158829dc0b92fb697234e121
3 years, 8 months ago (2017-04-25 04:58:10 UTC) #11
Benedikt Meurer
3 years, 7 months ago (2017-04-28 05:04:53 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2852623002/ by bmeurer@chromium.org.

The reason for reverting is: Breaks load:tools:drive story.

Powered by Google App Engine
This is Rietveld 408576698